Fix trigger for FilterCount

Author: rrrene

lib/credo/check/refactor/filter_count.ex

@@ -35,14 +35,14 @@ defmodule Credo.Check.Refactor.FilterCount do
             {:|>, _,
              [
                _,
-               {{:., meta, [{:__aliases__, _, [:Enum]}, :filter]}, _, _}
+               {{:., _, [{:__aliases__, _, [:Enum]}, :filter]}, _, _}
              ]},
-            {{:., _, [{:__aliases__, _, [:Enum]}, :count]}, _, []}
+            {{:., meta, [{:__aliases__, _, [:Enum]}, :count]}, _, []}
           ]} = ast,
          issues,
          issue_meta
        ) do
-    new_issue = issue_for(issue_meta, meta[:line], "filter_count")
+    new_issue = issue_for(issue_meta, meta[:line], "count")
     {ast, issues ++ List.wrap(new_issue)}
   end
 
@@ -54,20 +54,20 @@ defmodule Credo.Check.Refactor.FilterCount do
          issues,
          issue_meta
        ) do
-    new_issue = issue_for(issue_meta, meta[:line], "filter_count")
+    new_issue = issue_for(issue_meta, meta[:line], "count")
     {ast, issues ++ List.wrap(new_issue)}
   end
 
   defp traverse(
          {:|>, _,
           [
-            {{:., meta, [{:__aliases__, _, [:Enum]}, :filter]}, _, _},
-            {{:., _, [{:__aliases__, _, [:Enum]}, :count]}, _, []}
+            {{:., _, [{:__aliases__, _, [:Enum]}, :filter]}, _, _},
+            {{:., meta, [{:__aliases__, _, [:Enum]}, :count]}, _, []}
           ]} = ast,
          issues,
          issue_meta
        ) do
-    new_issue = issue_for(issue_meta, meta[:line], "filter_count")
+    new_issue = issue_for(issue_meta, meta[:line], "count")
     {ast, issues ++ List.wrap(new_issue)}
   end
 
@@ -79,7 +79,7 @@ defmodule Credo.Check.Refactor.FilterCount do
          issues,
          issue_meta
        ) do
-    new_issue = issue_for(issue_meta, meta[:line], "filter_count")
+    new_issue = issue_for(issue_meta, meta[:line], "count")
     {ast, issues ++ List.wrap(new_issue)}
   end
 

test/credo/check/refactor/filter_count_test.exs

@@ -108,7 +108,10 @@ defmodule Credo.Check.Refactor.FilterCountTest do
     """
     |> to_source_file
     |> run_check(@described_check)
-    |> assert_issue()
+    |> assert_issue(fn issue ->
+      assert issue.line_no == 5
+      assert issue.trigger == "count"
+    end)
   end
 
   test "it should report a violation when filter-count pipeline is part of a larger pipeline" do
@@ -138,7 +141,10 @@ defmodule Credo.Check.Refactor.FilterCountTest do
     """
     |> to_source_file
     |> run_check(@described_check)
-    |> assert_issue()
+    |> assert_issue(fn issue ->
+      assert issue.line_no == 3
+      assert issue.trigger == "count"
+    end)
   end
 
   test "it should report a violation when applying Enum.filter/2 to two arguments and passing result to Enum.count/1" do