Skip to content

Commit 91502ce

Browse files
committed
Fix warning for Credo.Check for Elixir 1.18
Fixes a warning that some generated clauses weren't called in a static test case
1 parent d4b9901 commit 91502ce

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

lib/credo/check.ex

+1-5
Original file line numberDiff line numberDiff line change
@@ -457,11 +457,7 @@ defmodule Credo.Check do
457457

458458
defoverridable Credo.Check
459459

460-
defp append_issues_and_timings([] = _issues, exec) do
461-
exec
462-
end
463-
464-
defp append_issues_and_timings([_ | _] = issues, exec) do
460+
defp append_issues_and_timings(issues, exec) do
465461
Credo.Execution.ExecutionIssues.append(exec, issues)
466462
end
467463
end

lib/credo/execution/execution_issues.ex

+2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ defmodule Credo.Execution.ExecutionIssues do
1414
end
1515

1616
@doc "Appends an `issue` for the specified `filename`."
17+
def append(_, [] = _issues), do: :ok
18+
1719
def append(%Execution{issues_pid: pid}, issues) when is_list(issues) do
1820
issues
1921
|> Enum.group_by(& &1.filename)

0 commit comments

Comments
 (0)