Skip to content

Commit 973d042

Browse files
committed
feat+refact+test(check): format_issue opts allow a custom category
1 parent 2143bd9 commit 973d042

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

lib/credo/check.ex

+3-4
Original file line numberDiff line numberDiff line change
@@ -691,14 +691,13 @@ defmodule Credo.Check do
691691
- `:column` Sets the issue's column.
692692
- `:exit_status` Sets the issue's exit_status.
693693
- `:severity` Sets the issue's severity.
694+
- `:category` Sets the issue's category.
694695
"""
695696
def format_issue(issue_meta, opts, check) do
696697
source_file = IssueMeta.source_file(issue_meta)
697698
params = IssueMeta.params(issue_meta)
698-
issue_category = Params.category(params, check)
699-
issue_base_priority = Params.priority(params, check)
700-
701-
priority = Priority.to_integer(issue_base_priority)
699+
issue_category = opts[:category] || Params.category(params, check)
700+
priority = params |> Params.priority(check) |> Priority.to_integer()
702701

703702
exit_status_or_category =
704703
opts[:exit_status] || Params.exit_status(params, check) || issue_category

test/credo/check_test.exs

+3-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ defmodule Credo.CheckTest do
6666
line_no: 3,
6767
column: 15,
6868
exit_status: 23,
69-
severity: 11
69+
severity: 11,
70+
category: :custom_category
7071
)
7172
]
7273
end
@@ -89,6 +90,7 @@ defmodule Credo.CheckTest do
8990
assert issue.column == 15
9091
assert issue.exit_status == 23
9192
assert issue.severity == 11
93+
assert issue.category == :custom_category
9294
end)
9395
end
9496
end

0 commit comments

Comments
 (0)