Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue: mention the need for a githubissue port #5

Open
ghost opened this issue Jul 6, 2019 · 1 comment
Open

issue: mention the need for a githubissue port #5

ghost opened this issue Jul 6, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 6, 2019

I got a panic while running issue -a.

This line failed to print the error message https://github.com/rsc/github/blob/master/issue/acme.go#L70. I eventually figured I had to add

plumb to githubissue

to ~/lib/plumbing but that's not in the documentation. The panic trace is similar to the below (similar because line number is influenced by some print's I've added).

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x230 pc=0x7b6509]

goroutine 21 [running]:
9fans.net/go/acme.(*Win).Err(...)
	/home/nicolagi/go/pkg/mod/9fans.net/[email protected]/acme/acme.go:895
main.(*awin).plumbserve(0xc0000a8480)
	/home/nicolagi/go/src/rsc.io/github/issue/acme.go:71 +0x149
created by main.acmeMode
	/home/nicolagi/go/src/rsc.io/github/issue/acme.go:62 +0x1f7
@ghost ghost changed the title Mention the need for a githubissue port in documentation issue: mention the need for a githubissue port Jul 6, 2019
jroimartin added a commit to jroimartin/github that referenced this issue Jan 11, 2020
@jroimartin
issue: fix nil pointer dereference on plumb error
62d3705 
plumbserve() fails with a nil pointer dereferrence when it tries to
print errors via w.Err(). This happens because w is a dummy window
with a nil *acme.Win. This commit  replaces w.Err() calls in
plumbserve() with log.Printf(). It also extracts the plumbserve()
method out of *awin, given that the previous change removes this
dependency.

Fixes issue rsc#5.
jroimartin added a commit to jroimartin/github that referenced this issue Jan 11, 2020
@jroimartin
issue: fix nil pointer dereference on plumb error
8fa163d 
plumbserve() fails with a nil pointer dereference when it tries to
print errors via w.Err(). This happens because w is a dummy window
with a nil *acme.Win. This commit  replaces w.Err() calls in
plumbserve() with log.Printf(). It also extracts the plumbserve()
method out of *awin, given that the previous change removes this
dependency.

Fixes issue rsc#5.
@jroimartin jroimartin mentioned this issue Jan 11, 2020
Open
jroimartin added a commit to jroimartin/github that referenced this issue Jan 12, 2020
@jroimartin
issue: fix nil pointer dereference on plumb error
6cc4f0b 
plumbserve() fails with a nil pointer dereference when it tries to
print errors via w.Err(). This happens because w is a dummy window
with a nil *acme.Win. This commit  replaces w.Err() calls in
plumbserve() with acme.Errf(). It also extracts the plumbserve()
method out of *awin, given that the previous change removes this
dependency.

Fixes issue rsc#5.
@yarikk
Copy link

yarikk commented Jul 22, 2021 •
edited
Loading

@rsc this is still the case ☝🏻

ollytom pushed a commit to ollytom/issues that referenced this issue Nov 3, 2024
@jroimartin @ollytom
issue: fix nil pointer dereference on plumb error
614d0c8 
plumbserve() fails with a nil pointer dereference when it tries to
print errors via w.Err(). This happens because w is a dummy window
with a nil *acme.Win. This commit  replaces w.Err() calls in
plumbserve() with acme.Errf(). It also extracts the plumbserve()
method out of *awin, given that the previous change removes this
dependency.

Fixes issue rsc#5.
ollytom pushed a commit to ollytom/issues that referenced this issue Nov 3, 2024
@jroimartin @ollytom
issue: fix nil pointer dereference on plumb error
4ea9357 
plumbserve() fails with a nil pointer dereference when it tries to
print errors via w.Err(). This happens because w is a dummy window
with a nil *acme.Win. This commit  replaces w.Err() calls in
plumbserve() with acme.Errf(). It also extracts the plumbserve()
method out of *awin, given that the previous change removes this
dependency.

Fixes issue rsc#5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yarikk