Skip to content

MultipleAssertions false positive with 'look-alike' assertion methods #321

Open
@MatzFan

Description

@MatzFan

All methods which start with "assert_" or "refute_" are currently assumed to be (and counted as) Minitest assertions. E.g.

With Minitest/MultipleAssertions Max of 1 the following registers an offense.

def test_asserts_once
  assert_equal(:assert_equal, Bar.assert_but_not_a_minitest_assertion)
end

Expected behavior

No offense should be registered, as only one Minitest assertion is called in the test.

Actual behavior

Offense is registered.

Steps to reproduce the problem

See above code sample

RuboCop version

$ [bundle exec] rubocop -V
1.66.1 (using Parser 3.3.5.0, rubocop-ast 1.32.3, running on ruby 3.3.5) [x86_64-linux]
  - rubocop-minitest 0.36.0
  - rubocop-performance 1.21.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions