Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultipleAssertions false positive with 'look-alike' assertion methods #321

Open
MatzFan opened this issue Sep 26, 2024 · 0 comments
Open

Comments

@MatzFan
Copy link

MatzFan commented Sep 26, 2024

All methods which start with "assert_" or "refute_" are currently assumed to be (and counted as) Minitest assertions. E.g.

With Minitest/MultipleAssertions Max of 1 the following registers an offense.

def test_asserts_once
  assert_equal(:assert_equal, Bar.assert_but_not_a_minitest_assertion)
end

Expected behavior

No offense should be registered, as only one Minitest assertion is called in the test.

Actual behavior

Offense is registered.

Steps to reproduce the problem

See above code sample

RuboCop version

$ [bundle exec] rubocop -V
1.66.1 (using Parser 3.3.5.0, rubocop-ast 1.32.3, running on ruby 3.3.5) [x86_64-linux]
  - rubocop-minitest 0.36.0
  - rubocop-performance 1.21.1
MatzFan pushed a commit to MatzFan/rubocop-minitest that referenced this issue Sep 26, 2024
MatzFan pushed a commit to MatzFan/rubocop-minitest that referenced this issue Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant