Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style for task dependency syntax #51

Open
ydakuka opened this issue Oct 14, 2023 · 1 comment
Open

Style for task dependency syntax #51

ydakuka opened this issue Oct 14, 2023 · 1 comment

Comments

@ydakuka
Copy link

ydakuka commented Oct 14, 2023

  1. Move the Rails/RakeEnvironment cop to rubocop-rake as the Rake/Rails/RakeEnvironment cop.

  2. The cop accepts two valid styles. I think one should be the preferred choice.

a)

desc 'delete non-unique banners'
task 'delete_non_unique_banners' => :environment do
  # ...
end

or

b)

desc 'delete non-unique banners'
task delete_non_unique_banners: :environment do
  # ...
end
@koic
Copy link
Member

koic commented Oct 14, 2023

This would be a style about task-dependent notation, not a cop for specific tasks.
NOTE: It should be checked for conflicts with Style/Hash cop.

@koic koic changed the title Add Rake/Rails/RakeEnvironment cop Style for task dependency syntax Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants