Skip to content

Commit 1029ca2

Browse files
author
BenTalagan
committed
Fix 'literal string will be frozen in the future' warnings with ruby 3.4
1 parent 5407445 commit 1029ca2

File tree

4 files changed

+19
-16
lines changed

4 files changed

+19
-16
lines changed

Gemfile

+2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
source "https://rubygems.org"
44

5+
56
group :development do
67
# excludes Windows, Rubinius and JRuby
78
gem "ruby-prof", :platforms => [:mri_19, :mri_20, :mri_21]
@@ -13,6 +14,7 @@ group :test do
1314
gem "rspec", ">= 3.8.0"
1415
gem "rspec-its"
1516
gem "simplecov"
17+
gem 'bigdecimal'
1618
end
1719

1820
group :development, :test do

codegen/protocol.rb.pytemplate

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# encoding: utf-8
22
# encoding: binary
3+
# frozen_string_literal: true
34

45
# THIS IS AN AUTOGENERATED FILE, DO NOT MODIFY
56
# IT DIRECTLY ! FOR CHANGES, PLEASE UPDATE FILES
@@ -142,7 +143,7 @@ module AMQ
142143
% for f in klass.fields:
143144
# <% i = klass.fields.index(f) %>1 << ${15 - i}
144145
def self.encode_${f.ruby_name}(value)
145-
buffer = ''
146+
buffer = +''
146147
% for line in helpers.genSingleEncode(spec, "value", f.domain):
147148
${line}
148149
% endfor

lib/amq/protocol/client.rb

+15-14
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# encoding: binary
2+
# frozen_string_literal: true
23

34
# THIS IS AN AUTOGENERATED FILE, DO NOT MODIFY
45
# IT DIRECTLY ! FOR CHANGES, PLEASE UPDATE FILES
@@ -1389,107 +1390,107 @@ class Basic < Protocol::Class
13891390

13901391
# 1 << 15
13911392
def self.encode_content_type(value)
1392-
buffer = ''
1393+
buffer = +''
13931394
buffer << value.to_s.bytesize.chr
13941395
buffer << value.to_s
13951396
[0, 0x8000, buffer]
13961397
end
13971398

13981399
# 1 << 14
13991400
def self.encode_content_encoding(value)
1400-
buffer = ''
1401+
buffer = +''
14011402
buffer << value.to_s.bytesize.chr
14021403
buffer << value.to_s
14031404
[1, 0x4000, buffer]
14041405
end
14051406

14061407
# 1 << 13
14071408
def self.encode_headers(value)
1408-
buffer = ''
1409+
buffer = +''
14091410
buffer << AMQ::Protocol::Table.encode(value)
14101411
[2, 0x2000, buffer]
14111412
end
14121413

14131414
# 1 << 12
14141415
def self.encode_delivery_mode(value)
1415-
buffer = ''
1416+
buffer = +''
14161417
buffer << [value].pack(PACK_CHAR)
14171418
[3, 0x1000, buffer]
14181419
end
14191420

14201421
# 1 << 11
14211422
def self.encode_priority(value)
1422-
buffer = ''
1423+
buffer = +''
14231424
buffer << [value].pack(PACK_CHAR)
14241425
[4, 0x0800, buffer]
14251426
end
14261427

14271428
# 1 << 10
14281429
def self.encode_correlation_id(value)
1429-
buffer = ''
1430+
buffer = +''
14301431
buffer << value.to_s.bytesize.chr
14311432
buffer << value.to_s
14321433
[5, 0x0400, buffer]
14331434
end
14341435

14351436
# 1 << 9
14361437
def self.encode_reply_to(value)
1437-
buffer = ''
1438+
buffer = +''
14381439
buffer << value.to_s.bytesize.chr
14391440
buffer << value.to_s
14401441
[6, 0x0200, buffer]
14411442
end
14421443

14431444
# 1 << 8
14441445
def self.encode_expiration(value)
1445-
buffer = ''
1446+
buffer = +''
14461447
buffer << value.to_s.bytesize.chr
14471448
buffer << value.to_s
14481449
[7, 0x0100, buffer]
14491450
end
14501451

14511452
# 1 << 7
14521453
def self.encode_message_id(value)
1453-
buffer = ''
1454+
buffer = +''
14541455
buffer << value.to_s.bytesize.chr
14551456
buffer << value.to_s
14561457
[8, 0x0080, buffer]
14571458
end
14581459

14591460
# 1 << 6
14601461
def self.encode_timestamp(value)
1461-
buffer = ''
1462+
buffer = +''
14621463
buffer << AMQ::Pack.pack_uint64_big_endian(value)
14631464
[9, 0x0040, buffer]
14641465
end
14651466

14661467
# 1 << 5
14671468
def self.encode_type(value)
1468-
buffer = ''
1469+
buffer = +''
14691470
buffer << value.to_s.bytesize.chr
14701471
buffer << value.to_s
14711472
[10, 0x0020, buffer]
14721473
end
14731474

14741475
# 1 << 4
14751476
def self.encode_user_id(value)
1476-
buffer = ''
1477+
buffer = +''
14771478
buffer << value.to_s.bytesize.chr
14781479
buffer << value.to_s
14791480
[11, 0x0010, buffer]
14801481
end
14811482

14821483
# 1 << 3
14831484
def self.encode_app_id(value)
1484-
buffer = ''
1485+
buffer = +''
14851486
buffer << value.to_s.bytesize.chr
14861487
buffer << value.to_s
14871488
[12, 0x0008, buffer]
14881489
end
14891490

14901491
# 1 << 2
14911492
def self.encode_cluster_id(value)
1492-
buffer = ''
1493+
buffer = +''
14931494
buffer << value.to_s.bytesize.chr
14941495
buffer << value.to_s
14951496
[13, 0x0004, buffer]

spec/amq/protocol/table_spec.rb

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
require 'bigdecimal'
21
require 'time'
32

43
module AMQ

0 commit comments

Comments
 (0)