Access to `Node#source` or `Location#source`?

[ioquatix]

I would like to access the source name, similar to how in the parser gem we can access node.source_buffer.name which is usually the file path.

Is that possible or can we make it possible? Maybe we can attach a name or some other metadata to the source object?

[kddnewton]

Do you need to do it through the node? It's available on the parse result, which is meant to funnel that kind of logic through that top-level interface. I was hoping to keep the fact that there is a source on the node/location as kind of opaque.

[ioquatix]

I understand your design and I'm okay if you don't want to expose it, but I don't store the parse results in my own AST, only the node.

Right now:

class Parser
  def self.parse(code, path)
    top = Prism.parse(code).value
    self.new.walk(top)
  end
  
  def walk(node, ...)
    if node.type == ...
      Thing.new(node)
    ...
end

class Thing
  def initialize(node)
    @node = node
  end

  def path
    # Previously node.source_buffer.name
    ???

I'd have to put the parse results into the instance of Thing which seems cumbersome, or alternatively pass in the path/source buffer as well as the node (was hoping to avoid this).

[kddnewton]

Sorry it took me so long to respond to this. I think I'd like to keep this as private. I'd like to maintain the ability to refactor this in the future without having to worry about it being public API. At the moment that "blessed" way is to pull the source off the parse result, so I think I'd like to keep it that way. Sorry!