Add braces to if/else and comment to empty capture early return in integer_at

jinroq · jinroq · commit 9285091956aa · 2026-04-05T16:40:01.000+09:00
diff --git a/ext/strscan/strscan.c b/ext/strscan/strscan.c
@@ -1949,12 +1949,14 @@ parse_decimal_fast(const char *ptr, long len)
             }
             if (!overflow) {
                 if (negative) {
-                    if (result == limit)
+                    if (result == limit) {
                         return LONG2NUM(LONG_MIN);
+                    }
                     return LONG2NUM(-(long)result);
                 }
-                else
+                else {
                     return LONG2NUM((long)result);
+                }
             }
         }
     }
@@ -2012,7 +2014,7 @@ strscan_integer_at(int argc, VALUE *argv, VALUE self)
     end = adjust_register_position(p, p->regs.end[i]);
     len = end - beg;
 
-    if (len <= 0) return INT2FIX(0);
+    if (len <= 0) return INT2FIX(0); /* empty capture: String#to_i("") == 0 */
 
     ptr = S_PBEG(p) + beg;
 

Original file line number	Diff line number	Diff line change
`@@ -1949,12 +1949,14 @@ parse_decimal_fast(const char *ptr, long len)`
`1949`	`1949`	`}`
`1950`	`1950`	`if (!overflow) {`
`1951`	`1951`	`if (negative) {`
`1952`		`- if (result == limit)`
	`1952`	`+ if (result == limit) {`
`1953`	`1953`	`return LONG2NUM(LONG_MIN);`
	`1954`	`+ }`
`1954`	`1955`	`return LONG2NUM(-(long)result);`
`1955`	`1956`	`}`
`1956`		`- else`
	`1957`	`+ else {`
`1957`	`1958`	`return LONG2NUM((long)result);`
	`1959`	`+ }`
`1958`	`1960`	`}`
`1959`	`1961`	`}`
`1960`	`1962`	`}`
`@@ -2012,7 +2014,7 @@ strscan_integer_at(int argc, VALUE *argv, VALUE self)`
`2012`	`2014`	`end = adjust_register_position(p, p->regs.end[i]);`
`2013`	`2015`	`len = end - beg;`
`2014`	`2016`
`2015`		`- if (len <= 0) return INT2FIX(0);`
	`2017`	`+ if (len <= 0) return INT2FIX(0); /* empty capture: String#to_i("") == 0 */`
`2016`	`2018`
`2017`	`2019`	`ptr = S_PBEG(p) + beg;`
`2018`	`2020`