Fix routing with the nopassword route helper

Author: bradgessler

README.md

@@ -25,7 +25,7 @@ Add the route to your `config/routes.rb`:
 nopassword EmailAuthenticationsController
 ```
 
-Restart the development server and head to `http://localhost:3000/email_authentication/new`.
+Restart the development server and head to `http://localhost:3000/email_authentications/new`.
 
 ## How It Works
 
@@ -148,17 +148,21 @@ class SessionsController < ApplicationController
 end
 ```
 
-Then define your own routes:
+Then use `nopassword` with your controller — the routes come with the concern:
 
 ```ruby
 # config/routes.rb
-resource :session, only: [:new, :create, :destroy] do
-  get ":id", action: :show, on: :collection
-  patch ":id", action: :update, on: :collection
-end
+nopassword SessionsController  # generates /sessions routes
+```
+
+The routes are derived from your controller name. To customize the path:
+
+```ruby
+# config/routes.rb
+nopassword SessionsController, path: "login"  # generates /login routes
 ```
 
-Or skip the concern entirely and use the models directly with your own views:
+Or skip the concern entirely and use the models directly with your own views and routes:
 
 ```ruby
 class SessionsController < ApplicationController

app/controllers/concerns/nopassword/email_authentication.rb

@@ -18,8 +18,8 @@ module EmailAuthentication
     included do
       include Routable
 
-      routes.draw do |controller|
-        resources :email_authentications, controller:, except: :destroy do
+      routes.draw do |controller, resource_name, **options|
+        resources resource_name, controller:, except: :destroy, **options do
           collection do
             delete :destroy
           end

lib/extensions/action_dispatch/routing/mapper.rb

@@ -3,7 +3,7 @@ module Routing
     class Mapper
       def nopassword(controller_class, *, **, &)
         if controller_class.respond_to?(:routes) and controller_class.routes.routable?
-          instance_exec(controller_class.controller_path, *, **, &controller_class.routes)
+          instance_exec(controller_class.controller_path, controller_class.controller_name, *, **, &controller_class.routes)
         else
           raise ArgumentError, "controller_class must respond to :routes"
         end

spec/routing/nopassword_routes_spec.rb

@@ -0,0 +1,43 @@
+require "rails_helper"
+
+RSpec.describe "nopassword routes" do
+  describe "path option" do
+    before do
+      Rails.application.routes.draw do
+        nopassword NoPassword::EmailAuthenticationsController, path: "login"
+      end
+    end
+
+    after do
+      Rails.application.reload_routes!
+    end
+
+    it "generates routes with custom path" do
+      expect(get: "/login/new").to route_to(controller: "nopassword/email_authentications", action: "new")
+      expect(post: "/login").to route_to(controller: "nopassword/email_authentications", action: "create")
+      expect(get: "/login/abc123").to route_to(controller: "nopassword/email_authentications", action: "show", id: "abc123")
+      expect(patch: "/login/abc123").to route_to(controller: "nopassword/email_authentications", action: "update", id: "abc123")
+      expect(delete: "/login").to route_to(controller: "nopassword/email_authentications", action: "destroy")
+    end
+  end
+
+  describe "default routes" do
+    before do
+      Rails.application.routes.draw do
+        nopassword NoPassword::EmailAuthenticationsController
+      end
+    end
+
+    after do
+      Rails.application.reload_routes!
+    end
+
+    it "generates routes based on controller name" do
+      expect(get: "/email_authentications/new").to route_to(controller: "nopassword/email_authentications", action: "new")
+      expect(post: "/email_authentications").to route_to(controller: "nopassword/email_authentications", action: "create")
+      expect(get: "/email_authentications/abc123").to route_to(controller: "nopassword/email_authentications", action: "show", id: "abc123")
+      expect(patch: "/email_authentications/abc123").to route_to(controller: "nopassword/email_authentications", action: "update", id: "abc123")
+      expect(delete: "/email_authentications").to route_to(controller: "nopassword/email_authentications", action: "destroy")
+    end
+  end
+end