Fix 3.2.0 load failures; release 3.2.1

trans · claude · trans · commit 2e674e395750 · 2026-06-14T20:57:47.000-04:00
3.2.0 deleted/renamed a number of method files but left stale require_relative lines pointing at them, so `require 'facets'` raised LoadError (issues #312, #315). Comment out the dead requires (the methods are now provided by Ruby) and correct the hash/to_proc -> hash/setter require after the rename (PR#313). Also stop Kernel::As from redefining object_id, which emitted a warning on every load (issue #310). Add a Rubytest-native regression test (test/core/load_paths_tc.rb) that statically verifies every require_relative target across lib/ resolves, so this class of breakage can't recur unnoticed. Released as a 3.2.x patch to restore loadability of the published line (3.2.0 cannot be yanked). The breaking-change/major-version concern from issue #314 is deferred to a future release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,5 +1,37 @@
 # Facets Release History
 
+## 3.2.1 / 2026-06-14
+
+Patch release that fixes the broken 3.2.0 release. 3.2.0 shipped with stale
+`require_relative` lines pointing at method files that had been removed or
+renamed, so `require 'facets'` raised `LoadError`. This restores loadability
+and adds a regression guard so it cannot recur. (The breaking-change and
+versioning concern raised in issue #314 is left for a future major release.)
+
+Changes:
+
+* New Features
+
+  * Add `OpenDSL` — build free-form, pluggable DSL modules from a block.
+  * Add `PIC` — COBOL-style edited-picture pattern matching as a simple
+    alternative to regular expressions.
+
+* Bug Fixes
+
+  * Fix `LoadError` on `require 'facets'`: remove stale `require_relative`
+    lines left pointing at removed method files, and correct the
+    `hash/to_proc` -> `hash/setter` require after the rename.
+    (issues #312, #315; PR#313)
+  * Fix `range.rb` requiring the removed `range/overlap`. (PR#318)
+  * Stop `Kernel::As` from redefining `object_id`, which emitted a
+    "redefining 'object_id' may cause serious problems" warning on load.
+    (issue #310)
+
+* Internal
+
+  * Add a load-path regression test that verifies every `require_relative`
+    target across the library resolves to an existing file.
+
 ## 3.2.0 / 2026-04-01
 
 Modernization release targeting Ruby 3.1+. Cleans up long-standing
diff --git a/facets.gemspec b/facets.gemspec
@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'facets'
-  s.version     = '3.2.0'
+  s.version     = '3.2.1'
   s.summary     = 'The premier collection of extension methods for Ruby.'
   s.description = 'Facets is the premier collection of extension methods for the Ruby ' \
                   'programming language. Facets extensions are unique by virtue of their ' \
diff --git a/lib/core/facets/array.rb b/lib/core/facets/array.rb
@@ -43,7 +43,7 @@
 require_relative 'array/squeeze.rb'
 require_relative 'array/store.rb'
 require_relative 'array/thru.rb'
-require_relative 'array/to_h.rb'
+#require_relative 'array/to_h.rb'  # removed: now provided by Ruby
 require_relative 'array/traverse.rb'
 require_relative 'array/uniq_by.rb'
 
diff --git a/lib/core/facets/dir.rb b/lib/core/facets/dir.rb
@@ -1,6 +1,6 @@
 require_relative 'dir/ascend.rb'
 require_relative 'dir/descend.rb'
-require_relative 'dir/each_child.rb'
+#require_relative 'dir/each_child.rb'  # removed: now provided by Ruby
 require_relative 'dir/multiglob.rb'
 require_relative 'dir/parent.rb'
 require_relative 'dir/recurse.rb'
diff --git a/lib/core/facets/enumerable.rb b/lib/core/facets/enumerable.rb
@@ -9,7 +9,7 @@
 require_relative 'enumerable/ewise.rb'
 require_relative 'enumerable/exclude.rb'
 require_relative 'enumerable/expand.rb'
-require_relative 'enumerable/filter.rb'
+#require_relative 'enumerable/filter.rb'  # removed: now provided by Ruby
 require_relative 'enumerable/find_yield.rb'
 require_relative 'enumerable/frequency.rb'
 require_relative 'enumerable/graph.rb'
@@ -31,7 +31,7 @@
 require_relative 'enumerable/purge.rb'
 require_relative 'enumerable/recursively.rb'
 require_relative 'enumerable/squeeze.rb'
-require_relative 'enumerable/sum.rb'
+#require_relative 'enumerable/sum.rb'  # removed: now provided by Ruby
 require_relative 'enumerable/value_by'
 #require_relative 'enumerable/unassociate.rb'
 require_relative 'enumerable/uniq_by.rb'
diff --git a/lib/core/facets/essentials.rb b/lib/core/facets/essentials.rb
@@ -16,7 +16,7 @@
 require_relative 'kernel/true'
 
 ### Object
-require_relative 'object/itself'
+#require_relative 'object/itself'  # removed: now provided by Ruby
 
 ### Array
 require_relative 'array/delete_values'
@@ -37,11 +37,11 @@
 require_relative 'enumerable/value_by'
 
 ### File
-require_relative 'file/write'
+#require_relative 'file/write'  # removed: now provided by Ruby
 
 ### Hash
 require_relative 'hash/autonew'
-require_relative 'hash/compact'
+#require_relative 'hash/compact'  # removed: now provided by Ruby
 #require_relative 'hash/data'
 require_relative 'hash/delete_values'
 require_relative 'hash/except'
diff --git a/lib/core/facets/file.rb b/lib/core/facets/file.rb
@@ -11,6 +11,6 @@
 require_relative 'file/sanitize.rb'
 require_relative 'file/split_all.rb'
 require_relative 'file/split_root.rb'
-require_relative 'file/write.rb'
+#require_relative 'file/write.rb'  # removed: now provided by Ruby
 require_relative 'file/writelines.rb'
 
diff --git a/lib/core/facets/hash.rb b/lib/core/facets/hash.rb
@@ -40,7 +40,7 @@
 require_relative 'hash/symbolize_keys.rb'
 require_relative 'hash/to_mod.rb'
 require_relative 'hash/to_options.rb'
-require_relative 'hash/to_proc.rb'
+require_relative 'hash/setter.rb'
 require_relative 'hash/to_struct.rb'
 require_relative 'hash/traverse.rb'
 require_relative 'hash/update.rb'
diff --git a/lib/core/facets/kernel/as.rb b/lib/core/facets/kernel/as.rb
@@ -99,8 +99,8 @@ def cache
     private :cache
   end
 
-  # Privatize all methods except #binding an operators.
-  private(*instance_methods.select { |m| m !~ /(^__|^\W|^binding$)/ })
+  # Privatize all methods except #binding, #object_id and operators.
+  private(*instance_methods.select { |m| m !~ /(^__|^\W|^binding$|^object_id$)/ })
 
   def initialize(subject, ancestor)
     @subject = subject
diff --git a/lib/core/facets/matchdata.rb b/lib/core/facets/matchdata.rb
@@ -1,3 +1,3 @@
-require_relative 'matchdata/match.rb'
+#require_relative 'matchdata/match.rb'  # removed: now provided by Ruby
 require_relative 'matchdata/matchset.rb'
 
diff --git a/lib/core/facets/numeric.rb b/lib/core/facets/numeric.rb
@@ -1,8 +1,8 @@
 require_relative 'numeric/approx.rb'
 require_relative 'numeric/distance.rb'
 require_relative 'numeric/length.rb'
-require_relative 'numeric/negative.rb'
-require_relative 'numeric/positive.rb'
+#require_relative 'numeric/negative.rb'  # removed: now provided by Ruby
+#require_relative 'numeric/positive.rb'  # removed: now provided by Ruby
 require_relative 'numeric/round_to.rb'
 require_relative 'numeric/spacing.rb'
 
diff --git a/lib/core/facets/object.rb b/lib/core/facets/object.rb
@@ -1,7 +1,7 @@
 # TODO: Is there a good reason for these to be here instead of in Kernel module?
 require_relative 'object/clone.rb'
 require_relative 'object/dup.rb'
-require_relative 'object/itself.rb'
+#require_relative 'object/itself.rb'  # removed: now provided by Ruby
 require_relative 'object/object_state.rb'
-require_relative 'object/try_dup.rb'
+#require_relative 'object/try_dup.rb'  # removed
 
diff --git a/lib/core/facets/process.rb b/lib/core/facets/process.rb
@@ -1,2 +1,2 @@
-require_relative 'process/daemon.rb'
+#require_relative 'process/daemon.rb'  # removed: now provided by Ruby
 
diff --git a/lib/core/facets/symbol.rb b/lib/core/facets/symbol.rb
@@ -8,7 +8,7 @@
 require_relative 'symbol/plain.rb'
 require_relative 'symbol/query.rb'
 require_relative 'symbol/setter.rb'
-require_relative 'symbol/succ.rb'
+#require_relative 'symbol/succ.rb'  # removed: now provided by Ruby
 require_relative 'symbol/thrown.rb'
 require_relative 'symbol/variablize.rb'
 
diff --git a/lib/core/facets/version.rb b/lib/core/facets/version.rb
@@ -1,3 +1,3 @@
 module Facets
-  VERSION = '3.2.0'
+  VERSION = '3.2.1'
 end
diff --git a/test/core/load_paths_tc.rb b/test/core/load_paths_tc.rb
@@ -0,0 +1,71 @@
+require 'ae'
+
+# Regression guard for the 3.2.0 load failures (issues #312, #315): method
+# files were removed or renamed, but stale `require_relative` lines were left
+# behind, so `require 'facets'` raised LoadError. This verifies that every
+# `require_relative` target across the library resolves to a real file, so the
+# whole class of breakage can't recur unnoticed.
+#
+# This is a Rubytest-native test rather than a Lemon unit test: Lemon targets
+# individual methods for coverage, which doesn't fit a library-wide invariant.
+# Rubytest's universal harness runs any object on $TEST_SUITE that responds to
+# #call/#each and #to_s. See https://rubyworks.github.io/rubytest.
+
+module FacetsLoadPaths
+
+  LIB_DIR = File.expand_path('../../lib', __dir__)
+
+  # Return a list of "file:line -> target" for every `require_relative` whose
+  # target file does not exist. Empty list means all load paths resolve.
+  def self.unresolved_requires
+    missing = []
+    Dir.glob(File.join(LIB_DIR, '**', '*.rb')).sort.each do |file|
+      dir = File.dirname(file)
+      File.foreach(file).with_index do |line, i|
+        next if line =~ /^\s*#/                       # skip commented-out requires
+        next unless line =~ /^\s*require_relative\s+["']([^"']+)["']/
+        target = $1
+        candidate = target.end_with?('.rb') ? target : "#{target}.rb"
+        unless File.exist?(File.expand_path(candidate, dir))
+          missing << "#{file.sub("#{LIB_DIR}/", '')}:#{i + 1} -> #{target}"
+        end
+      end
+    end
+    missing
+  end
+
+  # A single Rubytest-compliant test procedure. It must respond to #call and
+  # #to_s but NOT #each (a #each-responding object is treated as a case, not a
+  # test) -- so this is a plain class, not a Struct.
+  class Check
+    def initialize(description, &body)
+      @description = description
+      @body = body
+    end
+
+    def to_s
+      @description
+    end
+
+    def call
+      @body.call
+    end
+  end
+
+  # A Rubytest-compliant test case (responds to #each and #to_s).
+  class Case
+    def to_s
+      'Facets load paths'
+    end
+
+    def each
+      yield Check.new('every require_relative target resolves to an existing file') {
+        FacetsLoadPaths.unresolved_requires.assert == []
+        true
+      }
+    end
+  end
+
+end
+
+($TEST_SUITE ||= []) << FacetsLoadPaths::Case.new

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`		`-require_relative 'matchdata/match.rb'`
	`1`	`+#require_relative 'matchdata/match.rb' # removed: now provided by Ruby`
`2`	`2`	`require_relative 'matchdata/matchset.rb'`
`3`	`3`