From a4b4de7835bcca8b454770d034083734cceb871a Mon Sep 17 00:00:00 2001
From: MrCheeze <fishycheeze@yahoo.ca>
Date: Sun, 9 Mar 2025 21:06:52 -0400
Subject: [PATCH] avm2: Fix getChildByName to be case sensitive (close #19765)

---
 .../flash/display/display_object_container.rs    |   2 +-
 .../output.txt                                   |   5 +++++
 .../test.swf                                     | Bin 0 -> 1413 bytes
 .../test.toml                                    |   1 +
 4 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100644 tests/tests/swfs/avm2/displayobjectcontainer_getchildbyname_wrongcase/output.txt
 create mode 100644 tests/tests/swfs/avm2/displayobjectcontainer_getchildbyname_wrongcase/test.swf
 create mode 100644 tests/tests/swfs/avm2/displayobjectcontainer_getchildbyname_wrongcase/test.toml

diff --git a/core/src/avm2/globals/flash/display/display_object_container.rs b/core/src/avm2/globals/flash/display/display_object_container.rs
index d352ae51038eb..a0bfd832343f2 100644
--- a/core/src/avm2/globals/flash/display/display_object_container.rs
+++ b/core/src/avm2/globals/flash/display/display_object_container.rs
@@ -169,7 +169,7 @@ pub fn get_child_by_name<'gc>(
         .and_then(|this| this.as_container())
     {
         let name = args.get_string(activation, 0)?;
-        if let Some(child) = dobj.child_by_name(&name, false) {
+        if let Some(child) = dobj.child_by_name(&name, true) {
             return Ok(child.object2());
         } else {
             return Ok(Value::Null);
diff --git a/tests/tests/swfs/avm2/displayobjectcontainer_getchildbyname_wrongcase/output.txt b/tests/tests/swfs/avm2/displayobjectcontainer_getchildbyname_wrongcase/output.txt
new file mode 100644
index 0000000000000..5d47b5e64a110
--- /dev/null
+++ b/tests/tests/swfs/avm2/displayobjectcontainer_getchildbyname_wrongcase/output.txt
@@ -0,0 +1,5 @@
+//this.getChildByName("child_CLIP")
+null
+//this.addChild(newChild)
+//this.getChildByName("new_CHILD")
+null
diff --git a/tests/tests/swfs/avm2/displayobjectcontainer_getchildbyname_wrongcase/test.swf b/tests/tests/swfs/avm2/displayobjectcontainer_getchildbyname_wrongcase/test.swf
new file mode 100644
index 0000000000000000000000000000000000000000..938da3e2bfc8a2611a9fe0a7263d675cfdcece65
GIT binary patch
literal 1413
zcmV;01$z2JS5qrf3IG6joQ+mZY}-^Ee}1uJJKtGbH%-&8H0zo+OPsE3BL!BPcBP|T
ziVCcnS~X7c(ij{&v)!(pG-(2f0|IH<q)8kmaRF^&Hx7Ip=!DokVn|3xNaMB(qLmPu
zxRmEOY27XBuwwiD{{P?q^S$Sn4M42`;Qbtc00Acb3;-YvcXxLu+5zbCt#w3_k?F<A
zYUaY`Ni{h)flgnUR>X6PTsl>WgRM3v<`ZBck7U%F1Yiq%S`)0zfBZxC{#5{haqSjA
z1HE11*Z+(@qNgs+yn1OS05Sn^Vff~+!`GOf9x*@O_%3zh+sEMiV-Rh<dAIc%J^ttH
zUpoWW!M}HZd+_D$dy6p;{op>l{qTG7_c7qRc%7hb9UuE5_wbuvK=kT3k-K;C-Ju7-
zd*|{y?1#jap(i_6Z9m_c{v?2dvp$>x#7TW*w-fjU#xdTqx8dgiffb>z{`ec@OQKX*
z$xC7dY_&dNj2iIe199W^7U<KFrmqwwA(b|WY0O(mCQPF;(o0Gq(v-0$EUH2oC8LLv
zEW)FE!Z|^d-xkYA5@qzXzu_0KtWu^Sby~u>G1f})f~Zv_VUwLx)<tA!TAStMves)i
zGjLf$v^5Rv*zYYPqsujip$0Q<@t>+!Md_-LM=-+om2|z5N+g7Wl0)&lQck?Sa3V3n
z^CuIzHBr(<*=efQbWze;%vywe9%-7G6D3jKY}ALe_jRS>G7(Z$Mb#Q$9m%@pse=t2
zsj?u|&5Ae%QZ<K(R*_P!$5@q=oFIu;1YJ~QrztC=f+(=&SVp>gZxk=6<+}fhD#|$P
z)jg=-5J;_aHKAOwAS7%1X=<CAj>`2+beyMWe;CJ&_FEv5SB?2LC2L|mzgmy#`E8V?
z_5(AY+MoG@@&%l-jv@zzljb{<dk^LHv?A+xwvpO%kTfIX-U)eKTt_Cc^AIN?>tv*+
zjF+Jo^n3}aZHYu}mGqh`uQxA95-NCvLgB2jUKaAISke2MuP6(!o1wf<d3PU3#Q#j%
zT=Qz}W@pY^Of4Cawfa-LT-26?_43G4y-uZOmT#D?tRlU(A99;A&V8wCFKz3VY3u|T
zN%kiadP&sq>eFkrOl+RVn!)h?rV2+r2bClL!z6Cq%Y#uCZ_JgNh&0mbsC&RIu6Y=2
z?As{Q5QU!;WY1AJI`lk>BBKovuV-0rQ2o!y`k&JnD~dGz-ZX>>vxk1GE-q*<YH50Q
zW<DHsSim8brr(&EoeZ1pGsn%p$W{>JXpRjyIij5ocqu2<%Cs>Y*UkjE4lc-aav`pZ
z>E?R4UapS`GyP12Im!)i$GAZz$_;VDOf2XO9uLNYi69?L21h6_^;*zNy-5zx3`tO|
z!|8%<kJslv($d<-wFf$aouRJoo?csDxIc1q;Ml-m^e~!z$fSixmY|%N;`3tyR(AK8
zib4C(a1Tu|G<49Ui>BN(;h{+%P5Rjuf*mDTH$jspY0oJdo~Gf;G)&QOjBSDJIAmRr
z9fPbNvT4XpL3R|fZpgOSXmXrQ<L4Ajj<V*_Yy5Gr;hO{|Htuuyo;SykfQ${;pba1B
zBtFC`$k+jGvm1uAab#m51`L2CVGt;S!UGoI+hMEn)7S|l9L^&<N4AM7zYUj}*oh27
zY}=*{-&jLed8{KbwAnD^s(f_@EVDZ=Z4(htEjltR+=f_7Vm3Qm<q^m_`K*i2y7{b!
z&wBZ+kIzE<TLfL^RU&p?*$!Y6$}l;0m<iD^p)lQU#GkD4%fZ-eCP*v?tFgJWodh0M
zmwo4aK%lEdIyNDMFk#Y=VwmZ|yx93VJ!8_bFWT_sGi&KK>L4@SMitC{U(U27Ywd@i
T*#{M?n(oWmf2#igVZREzTr$1*

literal 0
HcmV?d00001

diff --git a/tests/tests/swfs/avm2/displayobjectcontainer_getchildbyname_wrongcase/test.toml b/tests/tests/swfs/avm2/displayobjectcontainer_getchildbyname_wrongcase/test.toml
new file mode 100644
index 0000000000000..dbee897f5863d
--- /dev/null
+++ b/tests/tests/swfs/avm2/displayobjectcontainer_getchildbyname_wrongcase/test.toml
@@ -0,0 +1 @@
+num_frames = 1