check that all commitstatus have the same pipeline Id

Author: rhariady

server/events/vcs/gitlab_client.go

@@ -424,7 +424,6 @@ func (g *GitlabClient) UpdateStatus(logger logging.SimpleLogging, repo models.Re
 	getCommitStatusesOptions := &gitlab.GetCommitStatusesOptions{
 		ListOptions: gitlab.ListOptions{
 			Sort:    "desc",
-			PerPage: 1,
 		},
 		Ref:     gitlab.Ptr(pull.HeadBranch),
 	}
@@ -440,10 +439,40 @@ func (g *GitlabClient) UpdateStatus(logger logging.SimpleLogging, repo models.Re
 			return err
 		}
 		if len(commitStatuses) > 0 {
-			logger.Info("Pipeline found for commit %s and ref %s, setting pipeline ID to %d", pull.HeadCommit, pull.HeadBranch, commitStatuses[0].PipelineId)
-			// Set the pipeline ID to the last pipeline that ran for the commit
-			setCommitStatusOptions.PipelineID = gitlab.Ptr(commitStatuses[0].PipelineId)
-			break
+			uniquePipelineIds := make(map[int]struct{})
+
+			// Loop through the commitStatuses to get unique pipeline Ids
+			for _, commitStatus := range commitStatuses {
+				// Ensure that commitStatus contain non-nil pipeline Id
+				if commitStatus.PipelineId == nil {
+					logger.Warn("Commit %s has status (id=%s) with no pipeline. Skipping.", pull.HeadCommit, commitStatus.ID)
+					continue
+				}
+				uniquePipelineIds[commitStatus.PipelineId] = struct{}{}
+			}
+
+			// Only set PipelineID if uniquePipelineIds is not empty
+			if len(uniquePipelineIds) > 0 {
+
+				// Ensure that all commit statuses has identical pipeline ID
+				if len(uniquePipelineIds) > 1 {
+					// Create a slice to hold all the unique pipelineIds
+					var pipelineIds []int
+
+					// Loop through the map and collect the pipelineIds
+					for pipelineId := range uniquePipelineIds {
+						pipelineIds = append(pipelineIds, pipelineId)
+					}
+
+					logger.Warn("Commit %s has statuses with more than one PipelineID (id=%s) for ref %s. Set PipelineID from the last commit status: %s", pull.HeadCommit, pipelineIds, pull.HeadBranch, commitStatuses[0].PipelineId)
+				} else {
+					logger.Info("Exactly one PipelineID found for commit %s and ref %s, setting new status PipelineID to %d", pull.HeadCommit, pull.HeadBranch, commitStatuses[0].PipelineId)
+				}
+
+				// Set the pipeline ID to the last pipeline that ran for the commit
+				setCommitStatusOptions.PipelineID = gitlab.Ptr(commitStatuses[0].PipelineId)
+				break
+			}
 		}
 		if i != retries {
 			logger.Info("No pipeline found for commit %s and ref %s, retrying in %s", pull.HeadCommit, pull.HeadBranch, delay)