Skip to content

Conversation

@milutin
Copy link
Contributor

@milutin milutin commented Aug 5, 2025

This pull request activates pre-existing, but previously disabled, support for the // @ts-ignore flag. This feature allows
developers to suppress diagnostics for specific template expressions.

The underlying logic for this functionality was already prepared in the codebase. This change simply enables it and adds a
corresponding test case to ensure it works as expected.

Changes

  • Uncommented and enabled the logic in find-tagged-templates.ts that checks for the // @ts-ignore comment before analyzing a
    tagged template expression.
  • If the comment is found, the expression is skipped, and no diagnostics are emitted for it.

Testing

  • Added a new test case in no-unclosed-tag.ts to verify that diagnostics are correctly suppressed when the // @ts-ignore flag is
    used.
  • All existing tests continue to pass, confirming no regressions were introduced.

milutin and others added 3 commits August 4, 2025 07:00
Update vscode-css-languageservice and vscode-html-languageservice versions

To support the latest css and html entities (properties, at-rules, etc) For example: text-wrap: pretty; and do not produce errors for it.
This change introduces support for the // @ts-ignore flag, allowing developers to suppress specific diagnostics.
Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @milutin!

My only question is why this was commented out. Did you happen to find the commit where it was, and maybe an explanation for it?

@milutin
Copy link
Contributor Author

milutin commented Aug 5, 2025

Awesome! Thanks @milutin!

My only question is why this was commented out. Did you happen to find the commit where it was, and maybe an explanation for it?

It was introduced 6 years ago (Feb 15, 2019) - c3332d8#diff-be07a06417d9eb7295e43679aa267f1b5d2514b3eed8e948070e5a469faa7a18

and it was commented out (Feb 21, 2019) - 29f0852#diff-3be198559aaba26431d093eb8ff25bfc6c68a41351b305b01b562016647c6112

Name of commits are just refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants