You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As it turned out from the integration tests we have, the bytes in constant operands may not always be populated in stable-mir, i.e. there can be null values in the byte sequence.
From inspection of the tests that fail on this, it appears as though the nulls' intention is to reserve space/pad memory for an optional value that is None, the None being represented as [0,0,0,0,0,0,0,0] and a sequence of 8 nulls following as padding for the size of the type that could be here.
Parsing the bytes values will be adapted to use zero for any null values.
* Removes the `AllocBytes` sort from `Allocation`, replacing it by
`MIRBytes`
* implements parser for `group(mir-bytes)`: an array of either `int` or
`null` is parsed into a byte string token (`b"..."`)
* parses `ProvenanceMapEntry` into a data structure rather than a list
of two `Int`
* removes a few other erratic `FIXME` comments
Fixes#449
---------
Co-authored-by: devops <[email protected]>
A few improvements to make working with the
KMIR-AST::Pgm
easier.AllocBytes
sort inbody.md
contains a sequence of optional byte values. This seems to be an unnecessary complication.ProvenanceMap
is currently parsed as a simpleInt
list but could be more structured.FIXME
notes from prior work on the python parser can be removed nowThe text was updated successfully, but these errors were encountered: