Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

449 simplify kmir types #450

Merged
merged 8 commits into from
Feb 10, 2025
Merged

449 simplify kmir types #450

merged 8 commits into from
Feb 10, 2025

Conversation

jberthold
Copy link
Member

  • Removes the AllocBytes sort from Allocation, replacing it by MIRBytes
  • implements parser for group(mir-bytes): an array of either int or null is parsed into a byte string token (b"...")
  • parses ProvenanceMapEntry into a data structure rather than a list of two Int
  • removes a few other erratic FIXME comments

Fixes #449

@jberthold jberthold marked this pull request as ready for review February 10, 2025 03:09
dkcumming
dkcumming approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@dkcumming dkcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't see if this shows in the .dot files, but maybe we could go through that in a meeting with the whole team.

kmir/src/tests/integration/data/run-rs/traits/defined-trait Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jberthold Did you mean to commit the binaries? I feel we generally would not commit them, but I don't think it's a big deal or anything.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that was a mistake when adding files. these are Linux binaries, rust compilation output from debugging

@automergerpr-permission-manager automergerpr-permission-manager bot merged commit aa96568 into master Feb 10, 2025
5 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the 449-simplify-kmir-types branch February 10, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkcumming dkcumming dkcumming approved these changes

@gtrepta gtrepta Awaiting requested review from gtrepta

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify sorts and review parsing in KMIR-AST
3 participants
@jberthold @dkcumming @rv-auditor