Skip to content

Commit e7a2b6c

Browse files
committed
Update readme and CI to use which 4.3.0 for 1.41.1 MSRV
1 parent fed768c commit e7a2b6c

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.github/workflows/test.yml

+4
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ jobs:
8383
with:
8484
toolchain: ${{ matrix.toolchain }}
8585
override: true
86+
- uses: actions-rs/cargo@v1
87+
with:
88+
command: update
89+
args: -p which --precise 4.3.0
8690
- uses: actions-rs/cargo@v1
8791
with:
8892
command: build

README.md

+2
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ let bitcoind = bitcoind::BitcoinD::new(bitcoind::downloaded_exe_path().unwrap())
3737

3838
The MSRV is 1.41.1 for version 0.29.* if no feature is used, otherwise is 1.57
3939

40+
Note: to respect 1.41.1 MSRV you need to use and older version of the which dependency, like it's done in the CI `cargo update -p [email protected]`. Pinning in `Cargo.toml` is avoided because it could cause compilation issues downstream.
41+
4042
## Issues with traditional approach
4143

4244
I used integration testing based on external bash script launching needed external processes, there are many issues with this approach like:

0 commit comments

Comments
 (0)