-
Notifications
You must be signed in to change notification settings - Fork 58
Open
Description
There are some of the RPC fields that have a different name in the model type and versioned type (Core names in snake case). Is this correct in all cases? If so are there equivalent fields that are not renamed? First mentioned here: #522 (comment)
An LLM search of all into.rs files found the below list:
| RPC | Version Type | Model Type | Rename | Versions |
|---|---|---|---|---|
| getblocktemplate | BlockTemplateTransaction | BlockTemplateTransaction | hash → wtxid |
v17 |
| gettxout | GetTxOut | GetTxOut | script_pubkey → address |
v17 |
| decodescript | DecodeScript | DecodeScript | hex → script_pubkey |
v17 |
| finalizepsbt | FinalizePsbt | FinalizePsbt | hex → tx |
v17 |
| descriptorprocesspsbt | DescriptorProcessPsbt | DescriptorProcessPsbt | hex → tx |
v26 |
| gettransaction | GetTransaction | GetTransaction | hex → tx |
v17, v19, v20, v23, v24, v26, v28 |
| createwallet | CreateWallet | CreateWallet | warning → warnings |
v17 |
| loadwallet | LoadWallet | LoadWallet | warning → warnings |
v17 |
| unloadwallet | UnloadWallet | UnloadWallet | warning → warnings |
v21 |
There are also cases where they are not renamed e.g. in the model types below:
pub struct BlockTemplateTransaction {
/// The transaction.
pub data: Transaction,
and
pub struct GetAddressInfo {
...
/// The redeemscript for the p2sh address.
// TODO: Should we rename this to redeem_script?
pub hex: Option<ScriptBuf>,
If they should be renamed it should be done consistently.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels