Skip to content

Commit 734d34e

Browse files
committed
Merge #740: fix: zero sequence check on relative time
c128e79 fix: zero sequence check on relative time (Chris Hyunhum Cho) Pull request description: I've just found out RelLockTime misses zero sequence check, which must be disallowed for miniscript. ACKs for top commit: apoelstra: ACK c128e79 successfully ran local tests Tree-SHA512: 9ccc96d67672c2077ec20efeda105e9941a1318030ac63b46e3260b886605d8a7231176413b4dccb6f1542008890f7df977bf4ed445f0fa9550cfa8f8dfaa0e7
2 parents 1a3605d + c128e79 commit 734d34e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/primitives/relative_locktime.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ impl RelLockTime {
6565
impl convert::TryFrom<Sequence> for RelLockTime {
6666
type Error = RelLockTimeError;
6767
fn try_from(seq: Sequence) -> Result<Self, RelLockTimeError> {
68-
if seq.is_relative_lock_time() {
68+
if seq.is_relative_lock_time() && seq != Sequence::ZERO {
6969
Ok(RelLockTime(seq))
7070
} else {
7171
Err(RelLockTimeError { value: seq.to_consensus_u32() })

0 commit comments

Comments
 (0)