Merge #694: Depend on the new bitcoind-json-rpc group of crates

9cf60c8 Depend on the new bitcoind-json-rpc group of crates (Tobin C. Harding)
f4752d1 CI: Add fuzz to CRATES (Tobin C. Harding)
de2370b Reduce coding convention attributes (Tobin C. Harding)
61a028a CI: Fix workflow docs (Tobin C. Harding)

Pull request description:

  There is an effort to improve the state of affairs in regards to integration testing extensively against multiple versions of Bitcoin Core. As part of this do:

  - Depend on the new `rust-bitcoind-json-rpc` crates
  - Run the integration tests against most versions of Core since 0.17.1

  (Note the latest supported version is currently 26.0)

  ref: https://crates.io/search?q=bitcoind-json-rpc

ACKs for top commit:
  apoelstra:
    ACK 9cf60c8 successfully ran local tests

Tree-SHA512: 296c978703addfa7e14541a78d4a302b23a48e6cefaf95a854f1a08d4598f68846c73775f1cfdc2a2788bcda1fe03ca73a686efbc88ed6fea5769f52569225a4

Author: apoelstra

.github/workflows/README.md

@@ -15,10 +15,11 @@ Run from `rust.yml` unless stated otherwise. Total 11 jobs.
 3.  `Nightly - minimal`
 4.  `Nightly - recent`
 5.  `MSRV - minimal`
-6.  `Lint`
-7.  `Docs`
-8.  `Docsrs`
-9.  `Bench`
-10. `Format`
-10. `Int-tests`
-11. `Embedded`
+6.  `MSRV - recent`
+7.  `Lint`
+8.  `Docs`
+9.  `Docsrs`
+10. `Bench`
+11. `Format`
+12. `Int-tests`
+13. `Embedded`

.github/workflows/rust.yml

@@ -167,7 +167,7 @@ jobs:
       - name: "Run test script"
         run: ./maintainer-tools/ci/run_task.sh bench
 
-  Format:                       #  1 jobs, run cargo fmt directly.
+  Format:                       #  1 job, run cargo fmt directly.
     name: Format - nightly toolchain
     runs-on: ubuntu-latest
     strategy:
@@ -182,20 +182,39 @@ jobs:
       - name: "Check formatting"
         run: cargo +nightly fmt --all -- --check
 
-  Int-tests:
-    name: Integration tests
+  Integration:                  # 1 job for each bitcoind version we support.
+    name: Integration tests - stable toolchain
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        feature:
+          [
+            "26_0",
+            "25_2",
+            "25_1",
+            "25_0",
+            "24_2",
+            "24_1",
+            "24_0_1",
+            "23_2",
+            "23_1",
+            "23_0",
+            "22_1",
+            "22_0",
+            "0_21_2",
+            "0_20_2",
+            "0_19_1",
+            "0_18_1",
+            "0_17_1",
+          ]
     steps:
-      - name: Checkout Crate
-        uses: actions/checkout@v2
-      - name: Checkout Toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
-      - name: Running integration tests
-        run: ./contrib/integration_test.sh
+      - name: "Checkout repo"
+        uses: actions/checkout@v4
+      - name: "Select toolchain"
+        uses: dtolnay/rust-toolchain@stable
+      - name: "Run integration tests"
+        run: cd bitcoind-tests && cargo test --features=${{ matrix.feature }}
 
   Embedded:
     runs-on: ubuntu-latest