Skip to content

Commit d6571b6

Browse files
committed
Depend on the new bitcoind-json-rpc group of crates
There is an effort to improve the state of affairs in regards to integration testing extensively against multiple versions of Bitcoin Core. As part of this do: - Depend on the new `rust-bitcoind-json-rpc` crates - Run the integration tests against most versions of Core since 0.17.1 (Note the latest supported version is currently 26.0) This patch effects integration testing only and should hopefully help with our upgrade process because I will personally make sure the new crates are ready and tested during the rust-bitcoin RC cycle. Note that we exclude the integration test crate `bitcoind-tests` from within the manifest, this has the effect of not covering it during all the jobs that use `run_task`. It is explicitly used in the `Integration` job.
1 parent a0e9028 commit d6571b6

File tree

8 files changed

+122
-532
lines changed

8 files changed

+122
-532
lines changed

.github/workflows/rust.yml

+31-12
Original file line numberDiff line numberDiff line change
@@ -182,20 +182,39 @@ jobs:
182182
- name: "Check formatting"
183183
run: cargo +nightly fmt --all -- --check
184184

185-
Int-tests:
186-
name: Integration tests
185+
Integration: # 1 job for each bitcoind version we support.
186+
name: Integration tests - stable toolchain
187187
runs-on: ubuntu-latest
188+
strategy:
189+
fail-fast: false
190+
matrix:
191+
feature:
192+
[
193+
"26_0",
194+
"25_2",
195+
"25_1",
196+
"25_0",
197+
"24_2",
198+
"24_1",
199+
"24_0_1",
200+
"23_2",
201+
"23_1",
202+
"23_0",
203+
"22_1",
204+
"22_0",
205+
"0_21_2",
206+
"0_20_2",
207+
"0_19_1",
208+
"0_18_1",
209+
"0_17_1",
210+
]
188211
steps:
189-
- name: Checkout Crate
190-
uses: actions/checkout@v2
191-
- name: Checkout Toolchain
192-
uses: actions-rs/toolchain@v1
193-
with:
194-
profile: minimal
195-
toolchain: stable
196-
override: true
197-
- name: Running integration tests
198-
run: ./contrib/integration_test.sh
212+
- name: "Checkout repo"
213+
uses: actions/checkout@v4
214+
- name: "Select toolchain"
215+
uses: dtolnay/rust-toolchain@stable
216+
- name: "Run integration tests"
217+
run: cd bitcoind-tests && cargo test --features=${{ matrix.feature }}
199218

200219
Embedded:
201220
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)