Skip to content

fuzz: panic in Descriptor::parse_descriptor with Invalid pkh() Input in rust_miniscript #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
i-am-yuvi opened this issue Apr 10, 2025 · 2 comments · May be fixed by #809
Open

fuzz: panic in Descriptor::parse_descriptor with Invalid pkh() Input in rust_miniscript #806

i-am-yuvi opened this issue Apr 10, 2025 · 2 comments · May be fixed by #809

Comments

@i-am-yuvi
Copy link

i-am-yuvi commented Apr 10, 2025 •
edited
Loading

No description provided.

@apoelstra
Copy link
Member

I believe this was closed in error (in bitcoinfuzz/bitcoinfuzz#146 it was mentioned that it's a dupe but I don't remember it).

@apoelstra apoelstra reopened this Apr 10, 2025
@i-am-yuvi
Copy link
Author

was

Thanks for reopening this!!

apoelstra added a commit to apoelstra/rust-miniscript that referenced this issue Apr 21, 2025
@apoelstra
add regression test for rust-bitcoin#806
4ff0840 
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse
as a string and then parse the keys. We fail to consider parsing errors
in the keys, resulting in a panic.

Also, clean up the panic message so it's clearer what's going on.
@apoelstra apoelstra linked a pull request Apr 21, 2025 that will close this issue
Open
apoelstra added a commit to apoelstra/rust-miniscript that referenced this issue Apr 21, 2025
@apoelstra
add regression test for rust-bitcoin#806
6bff186 
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse
as a string and then parse the keys. We fail to consider parsing errors
in the keys, resulting in a panic.

Also, clean up the panic message so it's clearer what's going on.
apoelstra added a commit to apoelstra/rust-miniscript that referenced this issue Apr 21, 2025
@apoelstra
add regression test for rust-bitcoin#806
4c6366a 
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse
as a string and then parse the keys. We fail to consider parsing errors
in the keys, resulting in a panic.

Also, clean up the panic message so it's clearer what's going on.
@brunoerg brunoerg mentioned this issue Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix crash in Descriptor::parse_desc found by fuzzer apoelstra/rust-miniscript
2 participants
@apoelstra @i-am-yuvi