Skip to content

Commit 297d5be

Browse files
committed
Test wasm with pinned dependencies
So far testing was was done unpinned however that risked randomly breaking builds whenever a dependency changes by accident. There was a note explicitly acknowledging lack of pinning but with no explanation why that was the case. So it might be because the author didn't want to bother and pinning can be implemented.
1 parent b6fd763 commit 297d5be

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/rust.yml

+5-3
Original file line numberDiff line numberDiff line change
@@ -254,16 +254,18 @@ jobs:
254254
run: cargo test --target i686-unknown-linux-gnu
255255

256256
WASM:
257-
name: WASM - stable toolchain
257+
name: WASM - MSRV toolchain
258258
runs-on: ubuntu-latest
259259
strategy:
260260
fail-fast: false
261-
# Note we do not use the recent lock file for wasm testing.
262261
steps:
263262
- name: "Checkout repo"
264263
uses: actions/checkout@v4
265264
- name: "Select toolchain"
266-
uses: dtolnay/rust-toolchain@stable
265+
uses: dtolnay/[email protected]
266+
- name: "Set dependencies"
267+
# For now we only use minimal lock
268+
run: cp Cargo-minimal.lock Cargo.lock
267269
- name: "Run wasm script"
268270
run: ./contrib/wasm.sh
269271

0 commit comments

Comments
 (0)