Merge #718: Remove check-for-api infrastructure

1b0c79c Remove check-for-api infrastructure (Tobin C. Harding)

Pull request description:

  This was a short lived, and unfortunately unsuccessful experiment on how to catch API breaking changes. As we did elsewhere in the org, remove the check-for-api infrastructure.

ACKs for top commit:
  apoelstra:
    ACK 1b0c79c successfully ran local tests

Tree-SHA512: 0fddf186d37af3863428af80ff5c5a941b0d1b40fd4d72b6c1bcf8dec1cb4127446d4d61e19cc12e2ff35a5cd3f98dce0980f913cc38a947dc4d12605b8bebe8

Author: apoelstra

.github/workflows/rust.yml

@@ -118,18 +118,3 @@ jobs:
         env:
           DO_WASM: true
         run: ./contrib/test.sh
-
-  API:
-    name: Check for changes to the public API
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-    steps:
-      - name: Checkout Crate
-        uses: actions/checkout@v3
-      - name: Checkout Toolchain
-        uses: dtolnay/rust-toolchain@nightly
-      - name: Install cargo-public-api
-        run: cargo install --locked cargo-public-api
-      - name: Running API checker script
-        run: ./contrib/check-for-api-changes.sh