Skip to content

Commit 74e6ced

Browse files
committed
Merge #604: Clarify the documentation of normalize_s
f6c68ec Clarify the documentation of `normalize_s` (Matt Corallo) Pull request description: I was reading the docs for `normalize_s` and got confused what the point was - it says that libsecp "will only accept" signatures that are normalized, which led me to believe it would refuse to deserialize such signatures. This is untrue, it only refuses to *validate* such signatures. ACKs for top commit: apoelstra: ACK f6c68ec Tree-SHA512: 27ac2f8819638fb889d0fbfb4bc1c07059854b8a15bf2dc2c4140eaf805eb15665fe3d87cadefd56c7b6200ef39818e8d6602e87d7ae7c1d4a4229d4829ea3d0
2 parents b0626b7 + f6c68ec commit 74e6ced

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/ecdsa/mod.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ impl Signature {
124124
/// changing even the signature itself can be a problem. Such applications
125125
/// require a "strong signature". It is believed that ECDSA is a strong
126126
/// signature except for this ambiguity in the sign of s, so to accommodate
127-
/// these applications libsecp256k1 will only accept signatures for which
128-
/// s is in the lower half of the field range. This eliminates the
127+
/// these applications libsecp256k1 considers signatures for which s is in
128+
/// the upper half of the field range invalid. This eliminates the
129129
/// ambiguity.
130130
///
131131
/// However, for some systems, signatures with high s-values are considered

0 commit comments

Comments
 (0)