Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--build-std cannot be negated or the documentation is incorrect #371

Open
ruuda opened this issue Apr 22, 2024 · 0 comments
Open

--build-std cannot be negated or the documentation is incorrect #371

ruuda opened this issue Apr 22, 2024 · 0 comments

Comments

@ruuda
Copy link
Contributor

ruuda commented Apr 22, 2024

In cargo-fuzz 0.12.0, there is an option --build-std which has the following help text:

      --build-std
          Pass -Zbuild-std to Cargo, which will build the standard library with all the build settings for the fuzz target, including debug assertions, and a sanitizer if requested. Currently this conflicts with coverage instrumentation but -Zbuild-std enables detecting more bugs so this option defaults to true, but when using `cargo fuzz coverage` it defaults to false

However, there is no negated --no-build-std option, and it doesn’t take an argument, so that would mean it is always turned on (except in cargo fuzz coverage, where the option is useless), with no way to turn it off, which would make this option useless.

I think that this is a mistake in the help text though, because without --build-std, I don’t see Cargo printing that it’s building any of the std crates and then the fuzzer works, but with --build-std it does build those crates. (And then it fails to build them, but that might just be a problem with the nightly version I’m using.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant