Skip to content

Commit b2a5a7a

Browse files
committed
Remove unnecessary clone
1 parent 57250ef commit b2a5a7a

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

src/librustdoc/passes/collect_intra_doc_links.rs

+2-7
Original file line numberDiff line numberDiff line change
@@ -1056,12 +1056,9 @@ impl<'a, 'tcx> DocFolder for LinkCollector<'a, 'tcx> {
10561056
}),
10571057
};
10581058

1059-
let mut candidates_iter =
1060-
candidates.iter().filter_map(|res| res.as_ref().ok());
1061-
let len = candidates_iter.clone().count();
1059+
let len = candidates.iter().filter(|res| res.is_ok()).count();
10621060

10631061
if len == 0 {
1064-
drop(candidates_iter);
10651062
resolution_failure(
10661063
self,
10671064
&item,
@@ -1076,12 +1073,10 @@ impl<'a, 'tcx> DocFolder for LinkCollector<'a, 'tcx> {
10761073
}
10771074

10781075
if len == 1 {
1079-
candidates_iter.next().unwrap().clone()
1076+
candidates.into_iter().filter_map(|res| res.ok()).next().unwrap()
10801077
} else if len == 2 && is_derive_trait_collision(&candidates) {
1081-
drop(candidates_iter);
10821078
candidates.type_ns.unwrap()
10831079
} else {
1084-
drop(candidates_iter);
10851080
if is_derive_trait_collision(&candidates) {
10861081
candidates.macro_ns = Err(ResolutionFailure::Dummy);
10871082
}

0 commit comments

Comments
 (0)