Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run downloads in parallel/asynchronously #120

Open
camelid opened this issue Oct 28, 2020 · 4 comments
Open

Run downloads in parallel/asynchronously #120

camelid opened this issue Oct 28, 2020 · 4 comments
Labels
A-downloading Area: downloading toolchains enhancement New feature or request

Comments

@camelid
Copy link
Member

camelid commented Oct 28, 2020

I think this would make bisecting faster.

The only downside I see is that it would be more difficult to have progress bars for each of the components. Perhaps we could have one progress bar that shows the total number of bytes that have been/need to be downloaded? Then each thread/async fn would lock the progress bar and update it every 1 MB or so.

@Mark-Simulacrum
Copy link
Member

I've always been of the opinion that this shouldn't make downloads faster because we should be entirely limited by network bandwidth -- that said, it would be good to confirm this (e.g., with curl or something running in parallel).

@camelid
Copy link
Member Author

camelid commented Oct 28, 2020

Yeah, unfortunately my internet ends up being 4 MB/s download speed, so bisecting can take a while :/

I use --preserve, so that helps, but then I use up a ton of disk space.

@Mark-Simulacrum
Copy link
Member

What we can do is parallelize compilation and downloading the next batch of artifacts. It would mean branch predicting that -- or downloading both -- but that seems not unreasonable. I guess if the compilation is fast enough it's not actually a win though.

@bjorn3
Copy link
Member

bjorn3 commented Oct 28, 2020

Re branch predicting: I once read that it can sometimes be quicker to divide the range in three using two comparisons and branches rather than dividing the range in two. The former biases the first branch to not taken instead of the pathological case of taken and not taken being equally likely.

@ehuss ehuss added enhancement New feature or request A-downloading Area: downloading toolchains labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-downloading Area: downloading toolchains enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants