Skip to content

Commit 30e5eec

Browse files
committed
fix: Improved error message when update --breaking invalid spec.
1 parent 619d550 commit 30e5eec

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

src/cargo/ops/cargo_update.rs

+5-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ use crate::util::toml_mut::manifest::LocalManifest;
1515
use crate::util::toml_mut::upgrade::upgrade_requirement;
1616
use crate::util::{style, OptVersionReq};
1717
use crate::util::{CargoResult, VersionExt};
18+
use anyhow::Context as _;
1819
use itertools::Itertools;
1920
use semver::{Op, Version, VersionReq};
2021
use std::cmp::Ordering;
@@ -269,7 +270,10 @@ pub fn upgrade_manifests(
269270

270271
let to_update = to_update
271272
.iter()
272-
.map(|s| PackageIdSpec::parse(s))
273+
.map(|spec| {
274+
PackageIdSpec::parse(spec)
275+
.with_context(|| format!("invalid package ID specification: `{spec}`"))
276+
})
273277
.collect::<Result<Vec<_>, _>>()?;
274278

275279
// Updates often require a lot of modifications to the registry, so ensure

tests/testsuite/update.rs

+4-1
Original file line numberDiff line numberDiff line change
@@ -2269,7 +2269,10 @@ fn update_breaking_spec_version() {
22692269
.masquerade_as_nightly_cargo(&["update-breaking"])
22702270
.with_status(101)
22712271
.with_stderr_data(str![[r#"
2272-
[ERROR] expected a version like "1.32"
2272+
[ERROR] invalid package ID specification: `incompatible@foo`
2273+
2274+
Caused by:
2275+
expected a version like "1.32"
22732276
22742277
"#]])
22752278
.run();

0 commit comments

Comments
 (0)