refactor: used vector instead of hashmap

Author: Gmin2

src/cargo/util/command_prelude.rs

@@ -25,7 +25,6 @@ use clap::builder::UnknownArgumentValueParser;
 use home::cargo_home_with_cwd;
 use semver::Version;
 use std::collections::HashMap;
-use std::collections::HashSet;
 use std::ffi::{OsStr, OsString};
 use std::path::Path;
 use std::path::PathBuf;
@@ -1129,53 +1128,40 @@ pub fn get_registry_candidates() -> CargoResult<Vec<clap_complete::CompletionCan
 
 fn get_feature_candidates() -> CargoResult<Vec<clap_complete::CompletionCandidate>> {
     let gctx = new_gctx_for_completions()?;
+    let manifest_path = find_root_manifest_for_wd(gctx.cwd())?;
+    let ws = Workspace::new(&manifest_path, &gctx)?;
+    let mut feature_candidates = Vec::new();
 
-    let manifest_path = match find_root_manifest_for_wd(gctx.cwd()) {
-        Ok(path) => path,
-        Err(_) => return Ok(Vec::new()),
-    };
-    let ws = match Workspace::new(&manifest_path, &gctx) {
-        Ok(ws) => ws,
-        Err(_) => return Ok(Vec::new()),
-    };
-
-    let mut features = HashSet::new();
-
-    // Process all packages in the workspace, collect features from all packages since --package could be used to select any of them
+    // Process all packages in the workspace
     for package in ws.members() {
+        let package_name = package.name();
+        
+        // Add direct features with package info
         for feature_name in package.summary().features().keys() {
-            features.insert(feature_name.as_str().to_string());
-        }
-
-        // Add optional dependencies as they can be enabled as features, these might not be in the features map if they are not explicitly referenced
-        for dep in package.dependencies() {
-            if dep.is_optional() {
-                features.insert(dep.name_in_toml().to_string());
-            }
+            feature_candidates.push(
+                clap_complete::CompletionCandidate::new(feature_name)
+                    .help(Some(format!("(from {})", package_name).into()))
+            );
         }
-
+        
         // Add qualified features for dependencies
         for dep in package.dependencies() {
-            let dep_name = dep.package_name().as_str().to_string();
-            // try to find this dependency in the workspace
-            if let Some(dep_pkg) = ws.members().find(|p| p.name().as_str() == dep_name) {
+            let dep_name = dep.name_in_toml();
+
+            // Try to find this dependency in the workspace
+            if let Some(dep_pkg) = ws.members().find(|p| p.name() == dep_name) {
                 for feat in dep_pkg.summary().features().keys() {
-                    features.insert(format!("{}/{}", dep_name, feat));
+                    let qualified_name = format!("{}/{}", dep_name, feat);
+                    feature_candidates.push(
+                        clap_complete::CompletionCandidate::new(qualified_name)
+                        .help(Some(format!("(from {})", dep_pkg.name()).into()))
+                    );
                 }
             }
         }
     }
-
-    // always include the default feature
-    features.insert("default".to_string());
-
-    let mut sorted_features: Vec<_> = features.into_iter().collect();
-    sorted_features.sort();
-
-    Ok(sorted_features
-        .into_iter()
-        .map(|name| clap_complete::CompletionCandidate::new(name))
-        .collect())
+    
+    Ok(feature_candidates)
 }
 
 fn get_profile_candidates() -> Vec<clap_complete::CompletionCandidate> {