Skip to content

Commit 5a2790e

Browse files
committed
Apply PR feedback
1 parent 1d61645 commit 5a2790e

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

Cargo.toml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@ parallel = ["dep:libc", "dep:jobserver"]
3333
# This is a placeholder feature for people who incorrectly used `cc` with `features = ["jobserver"]`
3434
# so that they aren't broken. This has never enabled `parallel`, so we won't do that.
3535
jobserver = []
36-
# Visual Studio doesn't have clang-cl (Clang/LLVM) installed by default as it's an optional module.
37-
# While GitHub Actions runners have it installed, it might cause some failing tests if you don't
38-
# have it. Run the tests with "--features disable-clang-cl-tests" if you want to disable related tests.
39-
disable-clang-cl-tests = []
4036

4137
[dev-dependencies]
4238
tempfile = "3"
@@ -51,3 +47,6 @@ members = [
5147

5248
[patch.crates-io]
5349
cc = { path = "." }
50+
51+
[lints.rust]
52+
unexpected_cfgs = { level = "allow", check-cfg = ['cfg(disable_clang_cl_tests)'] }

src/windows/find_tools.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1202,7 +1202,7 @@ mod impl_ {
12021202
}
12031203

12041204
#[test]
1205-
#[cfg(not(feature = "disable-clang-cl-tests"))]
1205+
#[cfg(not(disable_clang_cl_tests))]
12061206
fn test_find_llvm_tools() {
12071207
// Import StdEnvGetter from the parent module
12081208
use crate::windows::find_tools::StdEnvGetter;

tests/test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -853,7 +853,7 @@ fn clang_android() {
853853
}
854854

855855
#[cfg(windows)]
856-
#[cfg(not(feature = "disable-clang-cl-tests"))]
856+
#[cfg(not(disable_clang_cl_tests))]
857857
mod msvc_clang_cl_tests {
858858
use super::{reset_env, Test};
859859

0 commit comments

Comments
 (0)