-
Notifications
You must be signed in to change notification settings - Fork 601
/
.eslintrc.js
141 lines (132 loc) · 5.04 KB
/
.eslintrc.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
module.exports = {
root: true,
parser: '@babel/eslint-parser',
parserOptions: {
ecmaVersion: 2018,
sourceType: 'module',
requireConfigFile: false,
babelOptions: {
plugins: [['@babel/plugin-proposal-decorators', { decoratorsBeforeExport: true }]],
},
},
plugins: ['ember', 'ember-concurrency', 'prettier', 'import-helpers'],
extends: [
'eslint:recommended',
'plugin:ember/recommended',
'plugin:qunit/recommended',
'plugin:qunit-dom/recommended',
'plugin:unicorn/recommended',
'plugin:prettier/recommended',
],
env: {
browser: true,
},
rules: {
// it's fine to use `return` without a value and rely on the implicit `undefined` return value
'getter-return': 'off',
// declaration sort is taken care of by `import-helpers/order-imports`
'sort-imports': ['error', { ignoreDeclarationSort: true, ignoreCase: true }],
'prettier/prettier': 'error',
// disabled because we still use `this.set()` in a few places and it works just fine
'ember/classic-decorator-no-classic-methods': 'off',
// disabled because the alternatives are currently not worth the additional complexity
'ember/no-array-prototype-extensions': 'off',
'ember-concurrency/no-perform-without-catch': 'warn',
'ember-concurrency/require-task-name-suffix': 'error',
// disabled because of false positives in `assert.rejects()` calls
'qunit/require-expect': 'off',
// disabled because of false positives related to ember-concurrency usage
'unicorn/consistent-function-scoping': 'off',
'unicorn/explicit-length-check': ['error', { 'non-zero': 'not-equal' }],
// disabled because it conflicts with Ember.js conventions
'unicorn/no-anonymous-default-export': 'off',
// disabled because of false positives related to `EmberArray`
'unicorn/no-array-for-each': 'off',
// disabled because it is annoying in some cases...
'unicorn/no-await-expression-member': 'off',
// disabled because we need `null` since JSON has no `undefined`
'unicorn/no-null': 'off',
// disabled because this rule conflicts with prettier
'unicorn/no-nested-ternary': 'off',
// disabled because of unfixable false positives
'unicorn/prevent-abbreviations': 'off',
// disabled because we are targeting only browsers at the moment
'unicorn/prefer-global-this': 'off',
// disabled because we don't want to go all-in on ES6 modules for Node.js code yet
'unicorn/prefer-module': 'off',
// disabled because it seems unnecessary
'unicorn/prefer-number-properties': 'off',
// disabled because it seems unnecessary
'unicorn/prefer-reflect-apply': 'off',
// disabled because of false positives related to `EmberArray`
'unicorn/prefer-spread': 'off',
// disabled because it seems unnecessary
'unicorn/prefer-string-raw': 'off',
// disabled because of Sentry issues
'unicorn/prefer-string-replace-all': 'off',
// disabled because switch statements in JS are quite error-prone
'unicorn/prefer-switch': 'off',
// disabled because of false positives
'unicorn/consistent-destructuring': 'off',
'unicorn/filename-case': ['error', { case: 'kebabCase', ignore: ['^-'] }],
'import-helpers/order-imports': [
'error',
{
newlinesBetween: 'always',
groups: [
// Node.js built-in modules
'/^(assert|async_hooks|buffer|child_process|cluster|console|constants|crypto|dgram|dns|domain|events|fs|http|http2|https|inspector|module|net|os|path|perf_hooks|process|punycode|querystring|readline|repl|stream|string_decoder|timers|tls|trace_events|tty|url|util|v8|vm|zli)/',
// Testing modules
['/^(qunit|ember-qunit|@ember/test-helpers|ember-exam|htmlbars-inline-precompile)$/', '/^ember-exam\\//'],
// Ember.js modules
['/^@(ember|ember-data|glimmer)\\//', '/^(ember|ember-data|rsvp)$/', '/^ember-data\\//'],
['module'],
[`/^${require('./package.json').name}\\//`],
['parent', 'sibling', 'index'],
],
alphabetize: { order: 'asc', ignoreCase: true },
},
],
},
overrides: [
// test files
{
files: ['tests/**/*.js'],
rules: {
// disabled because of our nested `prepare()` functions
'unicorn/consistent-function-scoping': 'off',
// disabled because of false positives with `assert.dom(…).hasAttribute(…)`
'unicorn/prefer-dom-node-dataset': 'off',
},
},
// mirage files
{
files: ['mirage/**/*.js'],
rules: {
// disabled because of different `.find()` meaning
'unicorn/no-array-callback-reference': 'off',
},
},
// node files
{
files: [
'.eslintrc.js',
'.template-lintrc.js',
'ember-cli-build.js',
'testem.js',
'blueprints/*/index.js',
'config/**/*.js',
'lib/*/index.js',
'server/**/*.js',
],
parserOptions: {
sourceType: 'script',
ecmaVersion: 2018,
},
env: {
browser: false,
node: true,
},
},
],
};