Skip to content

Add Godbolt Command#77

Open
tinaun wants to merge 4 commits into
technetos:masterfrom
tinaun:godbolt
Open

Add Godbolt Command#77
tinaun wants to merge 4 commits into
technetos:masterfrom
tinaun:godbolt

Conversation

@tinaun
Copy link
Copy Markdown
Contributor

@tinaun tinaun commented Feb 2, 2021

Depends on #90

Comment thread src/commands.rs Outdated
Comment thread src/commands.rs Outdated
Comment thread src/commands.rs Outdated
@technetos
Copy link
Copy Markdown
Owner

Im all for adding a godbolt command but there are additional changes lumped into this PR. If you would like to see the godbolt command added please make a PR adding just that functionality.

Comment thread src/main.rs Outdated
@khionu
Copy link
Copy Markdown
Contributor

khionu commented Jun 20, 2021

Did you run cargo fmt on this?

Comment thread src/main.rs
});
}

cmds.add("?godbolt flags={} version={} ```\ncode```", |args| {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not use a closure here unless its necessary. Please move these into a fn and pass the fn pointer here instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants