Skip to content

"previous page" button never present in search results #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GuillaumeGomez opened this issue Jan 8, 2025 · 1 comment
Open

"previous page" button never present in search results #2711

GuillaumeGomez opened this issue Jan 8, 2025 · 1 comment
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR

Comments

@GuillaumeGomez
Copy link
Member

It's apparently because crates.io seek pagination doesn't allow it (without sacrifing performance) so it's up to us to fix it.

We can still use the old pagination system by providing the page number. I don't really see another way to fix it sadly...
@syphar
Copy link
Member

syphar commented Jan 9, 2025

I lean towards our search just being a thin wrapper on top of crates.io search.

Which could mean:
don't show a prev-button when there is no prev-link.

The old pagination system is quite tough on the database, so I wouldn't revert to using it for crates.io's sake.

@syphar syphar added C-bug Category: This is a bug A-frontend Area: Web frontend E-easy Effort: Should be easy to implement and would make a good first PR labels May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug E-easy Effort: Should be easy to implement and would make a good first PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syphar @GuillaumeGomez