Skip to content

Some fields are missing in BlameHunk #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kojiishi opened this issue Apr 29, 2025 · 5 comments
Open

Some fields are missing in BlameHunk #1157

kojiishi opened this issue Apr 29, 2025 · 5 comments

Comments

@kojiishi
Copy link

These fields are in the git_blame_hunk in the libgit2, but not in the rust BlameHunk.

Could these be added?
@weihanglo
Copy link
Member

You can access orig_path through BlameHunk::path.

@weihanglo
Copy link
Member

The only missing part AFAIK is {final,orig}_commiter which I think we are open to adding methods to access those.

@kojiishi
Copy link
Author

Oh, sorry, I was looking for the same name. Thank you for pointing this out.

@kojiishi
Copy link
Author

kojiishi commented May 4, 2025 •
edited
Loading

Comparing with git_blame_hunk, summary is missing, in addition to final_committer and orig_committer you mentioned?

@kojiishi kojiishi changed the title Some fields such as orig_path are missing in BlameHunk Some fields are missing in BlameHunk May 4, 2025
@weihanglo
Copy link
Member

On yeah summary is also missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kojiishi @weihanglo