Apply suggestions from code review

jhgg · Veykril · web-flow · commit d5de7c21b27e · 2021-11-17T09:53:24.000-08:00
Co-authored-by: Lukas Wirth &lt;lukastw97@gmail.com&gt;
diff --git a/crates/hir/src/lib.rs b/crates/hir/src/lib.rs
@@ -1458,14 +1458,7 @@ impl Const {
     }
 
     pub fn value(self, db: &dyn HirDatabase) -> Option<ast::Expr> {
-        let loc = self.id.lookup(db.upcast());
-        let item_tree = loc.id.item_tree(db.upcast());
-        let ast_id = item_tree[loc.id.value].ast_id;
-        let ast_id_map = db.ast_id_map(loc.id.file_id());
-        let ast_ptr = ast_id_map.get(ast_id);
-        let syntax_node = db.parse_or_expand(loc.id.file_id())?;
-        let ast_node = ast_ptr.to_node(&syntax_node);
-        ast_node.body()
+        self.source(db)?.value.body()
     }
 
     pub fn ty(self, db: &dyn HirDatabase) -> Type {

Original file line number	Diff line number	Diff line change
`@@ -1458,14 +1458,7 @@ impl Const {`
`1458`	`1458`	`}`
`1459`	`1459`
`1460`	`1460`	`pub fn value(self, db: &dyn HirDatabase) -> Option<ast::Expr> {`
`1461`		`- let loc = self.id.lookup(db.upcast());`
`1462`		`- let item_tree = loc.id.item_tree(db.upcast());`
`1463`		`- let ast_id = item_tree[loc.id.value].ast_id;`
`1464`		`- let ast_id_map = db.ast_id_map(loc.id.file_id());`
`1465`		`- let ast_ptr = ast_id_map.get(ast_id);`
`1466`		`- let syntax_node = db.parse_or_expand(loc.id.file_id())?;`
`1467`		`- let ast_node = ast_ptr.to_node(&syntax_node);`
`1468`		`- ast_node.body()`
	`1461`	`+ self.source(db)?.value.body()`
`1469`	`1462`	`}`
`1470`	`1463`
`1471`	`1464`	`pub fn ty(self, db: &dyn HirDatabase) -> Type {`