|
| 1 | +use crate::utils; |
| 2 | +use if_chain::if_chain; |
| 3 | +use rustc::declare_lint_pass; |
| 4 | +use rustc::hir::{BinOpKind, Expr, ExprKind}; |
| 5 | +use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; |
| 6 | +use rustc_errors::Applicability; |
| 7 | +use rustc_session::declare_tool_lint; |
| 8 | + |
| 9 | +declare_clippy_lint! { |
| 10 | + /// **What it does:** Use `std::ptr::eq` when applicable |
| 11 | + /// |
| 12 | + /// **Why is this bad?** `ptr::eq` can be used to compare `&T` references |
| 13 | + /// (which coerce to `*const T` implicitly) by their address rather than |
| 14 | + /// comparing the values they point to. |
| 15 | + /// |
| 16 | + /// **Known problems:** None |
| 17 | + /// |
| 18 | + /// **Example:** |
| 19 | + /// ```rust |
| 20 | + /// let a = &[1, 2, 3]; |
| 21 | + /// let b = &[1, 2, 3]; |
| 22 | + /// |
| 23 | + /// assert!(a as *const _ as usize == b as *const _ as usize); |
| 24 | + /// // Could be written |
| 25 | + /// assert!(std::ptr::eq(a, b)); |
| 26 | + /// ``` |
| 27 | + pub PTR_EQ, |
| 28 | + style, |
| 29 | + "use `std::ptr::eq` when comparing raw pointers" |
| 30 | +} |
| 31 | + |
| 32 | +declare_lint_pass!(PtrEqLint => [PTR_EQ]); |
| 33 | + |
| 34 | +static LINT_MSG: &str = "use `std::ptr::eq` when comparing raw pointers"; |
| 35 | + |
| 36 | +impl<'a, 'tcx> LateLintPass<'a, 'tcx> for PtrEqLint { |
| 37 | + fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) { |
| 38 | + if utils::in_macro(expr.span) { |
| 39 | + return; |
| 40 | + } |
| 41 | + |
| 42 | + if let ExprKind::Binary(ref op, ref left, ref right) = expr.kind { |
| 43 | + if BinOpKind::Eq == op.node { |
| 44 | + let (left, right) = match (expr_as_cast_to_usize(cx, left), expr_as_cast_to_usize(cx, right)) { |
| 45 | + (Some(lhs), Some(rhs)) => (lhs, rhs), |
| 46 | + _ => (&**left, &**right), |
| 47 | + }; |
| 48 | + |
| 49 | + if_chain! { |
| 50 | + if let Some(left_var) = expr_as_cast_to_raw_pointer(cx, left); |
| 51 | + if let Some(right_var) = expr_as_cast_to_raw_pointer(cx, right); |
| 52 | + if let Some(left_snip) = utils::snippet_opt(cx, left_var.span); |
| 53 | + if let Some(right_snip) = utils::snippet_opt(cx, right_var.span); |
| 54 | + then { |
| 55 | + utils::span_lint_and_sugg( |
| 56 | + cx, |
| 57 | + PTR_EQ, |
| 58 | + expr.span, |
| 59 | + LINT_MSG, |
| 60 | + "try", |
| 61 | + format!("std::ptr::eq({}, {})", left_snip, right_snip), |
| 62 | + Applicability::MachineApplicable, |
| 63 | + ); |
| 64 | + } |
| 65 | + } |
| 66 | + } |
| 67 | + } |
| 68 | + } |
| 69 | +} |
| 70 | + |
| 71 | +// If the given expression is a cast to an usize, return the lhs of the cast |
| 72 | +// E.g., `foo as *const _ as usize` returns `foo as *const _`. |
| 73 | +fn expr_as_cast_to_usize<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, cast_expr: &'tcx Expr) -> Option<&'tcx Expr> { |
| 74 | + if cx.tables.expr_ty(cast_expr) == cx.tcx.types.usize { |
| 75 | + if let ExprKind::Cast(ref expr, _) = cast_expr.kind { |
| 76 | + return Some(expr); |
| 77 | + } |
| 78 | + } |
| 79 | + None |
| 80 | +} |
| 81 | + |
| 82 | +// If the given expression is a cast to a `*const` pointer, return the lhs of the cast |
| 83 | +// E.g., `foo as *const _` returns `foo`. |
| 84 | +fn expr_as_cast_to_raw_pointer<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, cast_expr: &'tcx Expr) -> Option<&'tcx Expr> { |
| 85 | + if cx.tables.expr_ty(cast_expr).is_unsafe_ptr() { |
| 86 | + if let ExprKind::Cast(ref expr, _) = cast_expr.kind { |
| 87 | + return Some(expr); |
| 88 | + } |
| 89 | + } |
| 90 | + None |
| 91 | +} |
0 commit comments