Skip to content

Commit 4b1d13e

Browse files
committed
Enable internal feature when testing Clippy
Clippy has internal lints, that only get build and tested, when the `internal` feature is enabled. Those tests are just regular UI tests, but split out from the normal UI tests, because they usually don't have to be touched when changing something in Clippy. However, changes to Rust internals often require updates of the internal lints, just as for the Rest of the Clippy codebase. Currently I fix this fallout during the sync. But this can lead to sync blockers in rare occasions.
1 parent 41e0363 commit 4b1d13e

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/bootstrap/test.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,11 @@ impl Step for Clippy {
694694
let compiler = builder.compiler(stage, host);
695695

696696
builder
697-
.ensure(tool::Clippy { compiler, target: self.host, extra_features: Vec::new() })
697+
.ensure(tool::Clippy {
698+
compiler,
699+
target: self.host,
700+
extra_features: vec!["internal".into()],
701+
})
698702
.expect("in-tree tool");
699703
let mut cargo = tool::prepare_tool_cargo(
700704
builder,
@@ -704,7 +708,7 @@ impl Step for Clippy {
704708
"test",
705709
"src/tools/clippy",
706710
SourceType::InTree,
707-
&[],
711+
&["internal".into()],
708712
);
709713

710714
cargo.env("RUSTC_TEST_SUITE", builder.rustc(compiler));

0 commit comments

Comments
 (0)