Skip to content

Commit c314a5b

Browse files
Clarify note in rustc_ast_lowering still applies
Co-authored-by: Ralf Jung <[email protected]>
1 parent 4e01198 commit c314a5b

File tree

1 file changed

+3
-2
lines changed
  • compiler/rustc_hir_analysis/src/check

1 file changed

+3
-2
lines changed

compiler/rustc_hir_analysis/src/check/check.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,9 @@ fn add_abi_diag_help<T: EmissionGuarantee>(abi: ExternAbi, diag: &mut Diag<'_, T
5151
}
5252

5353
pub fn check_abi(tcx: TyCtxt<'_>, hir_id: hir::HirId, span: Span, abi: ExternAbi) {
54-
// FIXME: this should be checked earlier, e.g. in `rustc_ast_lowering`, to fix
55-
// things like #86232.
54+
// FIXME: This should be checked earlier, e.g. in `rustc_ast_lowering`, as this
55+
// currently only guards function imports, function definitions, and function pointer types.
56+
// Functions in trait declarations can still use "deprecated" ABIs without any warning.
5657

5758
match AbiMap::from_target(&tcx.sess.target).canonize_abi(abi, false) {
5859
AbiMapping::Direct(..) => (),

0 commit comments

Comments
 (0)