Skip to content

Tracking Issue for keylocker_x86 #134813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 of 4 tasks
sayantn opened this issue Dec 27, 2024 · 6 comments
Open
2 of 4 tasks

Tracking Issue for keylocker_x86 #134813

sayantn opened this issue Dec 27, 2024 · 6 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@sayantn
Copy link
Contributor

sayantn commented Dec 27, 2024 •
edited
Loading

Feature gate: #![feature(keylocker_x86)]

This is a tracking issue for the kl and widekl target features and the associated intrinsics in stdarch

Public API

The following target features and all their associated intrinsics

  • kl: Intel Key Locker
  • widekl: Intel Key Locker Wide

Steps / History

  • Add the target features to Rust
  • Add the Intrinsics and Feature Detection to stdarch
  • Final comment period (FCP)1
  • Stabilization PR

Unresolved Questions

  • None yet.

Implementation History

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩
@sayantn sayantn added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Dec 27, 2024
@sayantn sayantn mentioned this issue Dec 27, 2024
Merged
jieyouxu added a commit to jieyouxu/rust that referenced this issue Feb 3, 2025
@jieyouxu
Rollup merge of rust-lang#134814 - sayantn:keylocker, r=oli-obk
1c368e4 
Add `kl` and `widekl` target features, and the feature gate

This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc`

<!--
`@rustbot` label O-x86_64 O-x86_32 A-target-feature
r? compiler
-->
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 3, 2025
@matthiaskrgr
Rollup merge of rust-lang#134814 - sayantn:keylocker, r=oli-obk
c987c91 
Add `kl` and `widekl` target features, and the feature gate

This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc`

<!--
``@rustbot`` label O-x86_64 O-x86_32 A-target-feature
r? compiler
-->
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 4, 2025
@matthiaskrgr
Rollup merge of rust-lang#134814 - sayantn:keylocker, r=oli-obk
e4eedb5 
Add `kl` and `widekl` target features, and the feature gate

This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc`

<!--
```@rustbot``` label O-x86_64 O-x86_32 A-target-feature
r? compiler
-->
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 4, 2025
@rust-timer
Unrolled build for rust-lang#134814
b6eccef 
Rollup merge of rust-lang#134814 - sayantn:keylocker, r=oli-obk

Add `kl` and `widekl` target features, and the feature gate

This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc`

<!--
```@rustbot``` label O-x86_64 O-x86_32 A-target-feature
r? compiler
-->
@sayantn sayantn mentioned this issue Feb 5, 2025
Merged
@sayantn
Copy link
Contributor Author

sayantn commented May 4, 2025 •
edited
Loading

cc @rust-lang/lang
cc @Amanieu

I believe this is also ready for stabilization, as all the intrinsics have been implemented already.

@rustbot label I-lang-nominated

@rustbot rustbot added the I-lang-nominated Nominated for discussion during a lang team meeting. label May 4, 2025
@traviscross
Copy link
Contributor

@rustbot labels -I-lang-nominated

We do our stabilization FCPs on stabilization PRs. Please submit and nominate one of those for us along with the stabilization report. See the new template for that:

rust-lang/rustc-dev-guide#2219

@rustbot rustbot removed the I-lang-nominated Nominated for discussion during a lang team meeting. label May 7, 2025
@traviscross traviscross added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label May 7, 2025
This was referenced May 7, 2025
Open
Open
@sayantn
Copy link
Contributor Author

sayantn commented May 7, 2025

The lang-stabilization is being done in #140766, so let's do the libs stabilization here (intrinsics and runtime detection, in rust-lang/stdarch#1795)

@rustbot label I-libs-api-nominated

@rustbot rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label May 7, 2025
@joshtriplett joshtriplett removed the T-lang Relevant to the language team, which will review and decide on the PR/issue. label May 20, 2025
@joshtriplett
Copy link
Member

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented May 20, 2025 •
edited by Amanieu
Loading

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 20, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented May 20, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label May 20, 2025
@joshtriplett joshtriplett removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joshtriplett @traviscross @rfcbot @rustbot @sayantn