Tracking Issue for keylocker_x86
#134813
Labels
C-tracking-issue
Category: An issue tracking the progress of sth. like the implementation of an RFC
disposition-merge
This issue / PR is in PFCP or FCP with a disposition to merge it.
finished-final-comment-period
The final comment period is finished for this PR / Issue.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
sayantn
added
C-tracking-issue
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this issue
Feb 3, 2025
Add `kl` and `widekl` target features, and the feature gate This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc` <!-- `@rustbot` label O-x86_64 O-x86_32 A-target-feature r? compiler -->
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 3, 2025
Add `kl` and `widekl` target features, and the feature gate This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc` <!-- ``@rustbot`` label O-x86_64 O-x86_32 A-target-feature r? compiler -->
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 4, 2025
Add `kl` and `widekl` target features, and the feature gate This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc` <!-- ```@rustbot``` label O-x86_64 O-x86_32 A-target-feature r? compiler -->
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Feb 4, 2025
Rollup merge of rust-lang#134814 - sayantn:keylocker, r=oli-obk Add `kl` and `widekl` target features, and the feature gate This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc` <!-- ```@rustbot``` label O-x86_64 O-x86_32 A-target-feature r? compiler -->
rustbot
added
the
I-lang-nominated
|
@rustbot labels -I-lang-nominated We do our stabilization FCPs on stabilization PRs. Please submit and nominate one of those for us along with the stabilization report. See the new template for that: |
rustbot
removed
the
I-lang-nominated
This was referenced May 7, 2025
Merged
|
The lang-stabilization is being done in #140766, so let's do the libs stabilization here (intrinsics and runtime detection, in rust-lang/stdarch#1795) @rustbot label I-libs-api-nominated |
rustbot
added
the
I-libs-api-nominated
|
@rfcbot merge |
|
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
removed
the
proposed-final-comment-period
joshtriplett
removed
the
I-libs-api-nominated
rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this issue
Jun 10, 2025
…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc `@rust-lang/lang` cc `@rust-lang/libs-api` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc `@Amanieu.` I will send the reference pr soon.
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this issue
Jun 10, 2025
…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ``@rust-lang/lang`` cc ``@rust-lang/libs-api`` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ``@Amanieu.`` I will send the reference pr soon.
fmease
added a commit
to fmease/rust
that referenced
this issue
Jun 10, 2025
…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ```@rust-lang/lang``` cc ```@rust-lang/libs-api``` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ```@Amanieu.``` I will send the reference pr soon.
fmease
added a commit
to fmease/rust
that referenced
this issue
Jun 10, 2025
…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ````@rust-lang/lang```` cc ````@rust-lang/libs-api```` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ````@Amanieu.```` I will send the reference pr soon.
rust-timer
added a commit
that referenced
this issue
Jun 10, 2025
Rollup merge of #140766 - sayantn:stabilize-keylocker, r=traviscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue #134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - #134814 - rust-lang/stdarch#1706 - #136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - #141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ````@rust-lang/lang```` cc ````@rust-lang/libs-api```` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ````@Amanieu.```` I will send the reference pr soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Feature gate:
#![feature(keylocker_x86)]This is a tracking issue for the
klandwidekltarget features and the associated intrinsics instdarchPublic API
The following target features and all their associated intrinsics
kl: Intel Key Lockerwidekl: Intel Key Locker WideSteps / History
stdarchUnresolved Questions
Implementation History
klandwidekltarget features, and the feature gate #134814klandwidekl) intrinsics and runtime feature detection stdarch#1706Footnotes
https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩
The text was updated successfully, but these errors were encountered: