rework opaque types for the new solver #111131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
now the annoying part of adding the impl trait tests to also run with the new solver
|
☔ The latest upstream changes (presumably #111358) made this pull request unmergeable. Please resolve the merge conflicts. |
|
going to close this for now, ended up prefering a slightly different approach and also want to discuss TAIT in a types meeting before putting more energy in this approach, given that it may conflict with the design we actually want to end up with. |
rust-cloud-vms bot
pushed a commit
to compiler-errors/rust
that referenced
this pull request
May 25, 2023
…::normalize_opaque_type Co-authored-by: lcnr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is currently still a mess and has multiple known bugs.
will keep working on it until we can land it. I am currently limiting the new behavior to only apply for the new trait solver but I intend to move it to the old solver as well. Not sure whether that should happen as part of this PR though.