Port #[link_ordinal] to the new attribute parsing infrastructure #143217

Periodic1911 · 2025-06-29T21:45:32Z

Ports link_ordinal to the new attribute parsing infrastructure for #131229 (comment)

bors · 2025-06-30T18:53:12Z

☔ The latest upstream changes (presumably #143233) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-07-07T06:03:34Z

☔ The latest upstream changes (presumably #143556) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-07-07T17:46:15Z

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-07T17:46:16Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Periodic1911 · 2025-07-07T17:46:56Z

Ports link_ordinal to the new attribute parsing infrastructure for #131229 (comment)

r? @oli-obk

cc @JonathanBrouwer @jdonszelmann

Periodic1911 · 2025-07-07T17:48:44Z

This is a windows-only attribute. I ran the ui test suite on Windows 11, but maybe a try run is in order? Up to you @oli-obk

JonathanBrouwer · 2025-07-07T19:40:25Z

Lemme see if I can do that: (probably not?)
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2

rust-bors · 2025-07-07T19:40:28Z

@JonathanBrouwer: 🔑 Insufficient privileges: not in try users

WaffleLapkin · 2025-07-08T02:25:05Z

@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2

rust-bors · 2025-07-08T02:25:10Z

⌛ Trying commit d92419f with merge a87fe92…

To cancel the try build, run the command @bors2 try cancel.

Port #[link_ordinal] to the new attribute parsing infrastructure Ports link_ordinal to the new attribute parsing infrastructure for #131229 (comment) try-job: x86_64-msvc-1 try-job: x86_64-msvc-2

rust-bors · 2025-07-08T05:01:35Z

☀️ Try build successful (CI)
Build commit: a87fe92 (a87fe92b9dfa0185a28b970728af94da59a58ce0, parent: a2d45f73c70d9dec57140c9412f83586eda895f8)

oli-obk · 2025-07-08T07:03:12Z

compiler/rustc_attr_data_structures/src/encode_cross_crate.rs

@@ -29,6 +29,7 @@ impl AttributeKind {
            Ignore { .. } => No,
            Inline(..) => No,
            LinkName { .. } => Yes,
+            LinkOrdinal { .. } => Yes,


I can't find where this was previously encoded cross crate. Isn't it simply part of codegen_fn_attrs and otherwise we don't need to store the attribute itself?

This was encoded cross crate in compiler/rustc_feature/src/builtin_attrs.rs:498 , but maybe it shouldn't be. I have changed it to not be cross crate, but we should do a try run to be sure no test uses link_ordinal cross crate.

jdonszelmann · 2025-07-13T10:58:20Z

@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2

rust-bors · 2025-07-13T10:58:23Z

⌛ Trying commit 75561c4 with merge 895fc72…

To cancel the try build, run the command @bors2 try cancel.

Port #[link_ordinal] to the new attribute parsing infrastructure Ports link_ordinal to the new attribute parsing infrastructure for #131229 (comment) try-job: x86_64-msvc-1 try-job: x86_64-msvc-2

rust-bors · 2025-07-13T13:28:51Z

☀️ Try build successful (CI)
Build commit: 895fc72 (895fc72109aa6979fedd3f05a4bd4c8cdac4b091, parent: d2baa49a106fad06fbf6202fb6ea8a0b3d2767cc)

jdonszelmann · 2025-07-13T15:07:29Z

Looks good?

jdonszelmann · 2025-07-13T15:07:51Z

@bors r+ rollup

bors · 2025-07-13T15:07:54Z

📌 Commit 75561c4 has been approved by jdonszelmann

It is now in the queue for this repository.

…zelmann Port #[link_ordinal] to the new attribute parsing infrastructure Ports link_ordinal to the new attribute parsing infrastructure for rust-lang#131229 (comment)

Rollup of 8 pull requests Successful merges: - #142885 (core: Add `BorrowedCursor::with_unfilled_buf`) - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143724 (Tidy cleanup) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - #143880 (tests: Test line debuginfo for linebreaked function parameters) Failed merges: - #143630 (Drop `./x suggest`) - #143733 (Change bootstrap's `tool.TOOL_NAME.features` to work on any subcommand) r? `@ghost` `@rustbot` modify labels: rollup

…zelmann Port #[link_ordinal] to the new attribute parsing infrastructure Ports link_ordinal to the new attribute parsing infrastructure for rust-lang#131229 (comment)

Rollup of 16 pull requests Successful merges: - #142885 (core: Add `BorrowedCursor::with_unfilled_buf`) - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143592 (UWP: link ntdll functions using raw-dylib) - #143681 (bootstrap/miri: avoid rebuilds for test builds) - #143710 (Updates to random number generation APIs) - #143724 (Tidy cleanup) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - #143855 (Port `#[omit_gdb_pretty_printer_section]` to the new attribute parsing) - #143868 (warn on align on fields to avoid breaking changes) - #143875 (update issue number for `const_trait_impl`) - #143881 (Use zero for initialized Once state) - #143887 (Run bootstrap tests sooner in the `x test` pipeline) - #143893 (Don't require `eh_personality` lang item on targets that have a personality) Failed merges: - #143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - #143891 (Port `#[coverage]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup

…zelmann Port #[link_ordinal] to the new attribute parsing infrastructure Ports link_ordinal to the new attribute parsing infrastructure for rust-lang#131229 (comment)

Rollup of 17 pull requests Successful merges: - #142885 (core: Add `BorrowedCursor::with_unfilled_buf`) - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143681 (bootstrap/miri: avoid rebuilds for test builds) - #143710 (Updates to random number generation APIs) - #143724 (Tidy cleanup) - #143738 (Move several float tests to floats/mod.rs) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - #143855 (Port `#[omit_gdb_pretty_printer_section]` to the new attribute parsing) - #143868 (warn on align on fields to avoid breaking changes) - #143875 (update issue number for `const_trait_impl`) - #143881 (Use zero for initialized Once state) - #143887 (Run bootstrap tests sooner in the `x test` pipeline) - #143893 (Don't require `eh_personality` lang item on targets that have a personality) - #143901 (Region constraint nits) Failed merges: - #143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - #143891 (Port `#[coverage]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - #143681 (bootstrap/miri: avoid rebuilds for test builds) - #143724 (Tidy cleanup) - #143733 (Change bootstrap's `tool.TOOL_NAME.features` to work on any subcommand) - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - #143875 (update issue number for `const_trait_impl`) - #143881 (Use zero for initialized Once state) - #143887 (Run bootstrap tests sooner in the `x test` pipeline) - #143917 (Change "allocated object" to "allocation".) - #143918 (Tier check cleanup) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143217 - Periodic1911:link-ordinal, r=jdonszelmann Port #[link_ordinal] to the new attribute parsing infrastructure Ports link_ordinal to the new attribute parsing infrastructure for #131229 (comment)

Rollup of 10 pull requests Successful merges: - rust-lang/rust#143217 (Port #[link_ordinal] to the new attribute parsing infrastructure) - rust-lang/rust#143681 (bootstrap/miri: avoid rebuilds for test builds) - rust-lang/rust#143724 (Tidy cleanup) - rust-lang/rust#143733 (Change bootstrap's `tool.TOOL_NAME.features` to work on any subcommand) - rust-lang/rust#143850 (Compiletest: Simplify {Html,Json}DocCk directive handling) - rust-lang/rust#143875 (update issue number for `const_trait_impl`) - rust-lang/rust#143881 (Use zero for initialized Once state) - rust-lang/rust#143887 (Run bootstrap tests sooner in the `x test` pipeline) - rust-lang/rust#143917 (Change "allocated object" to "allocation".) - rust-lang/rust#143918 (Tier check cleanup) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 29, 2025

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 30, 2025

Periodic1911 force-pushed the link-ordinal branch from 38ee95d to b85d685 Compare July 6, 2025 20:17

This comment has been minimized.

Sign in to view

Periodic1911 force-pushed the link-ordinal branch from 84cdff7 to 929b899 Compare July 7, 2025 13:08

This comment has been minimized.

Sign in to view

Periodic1911 force-pushed the link-ordinal branch from 6c7538d to d92419f Compare July 7, 2025 16:34

Periodic1911 marked this pull request as ready for review July 7, 2025 17:46

rustbot assigned lcnr Jul 7, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2025

rustbot assigned oli-obk and unassigned lcnr Jul 7, 2025

oli-obk reviewed Jul 8, 2025

View reviewed changes

jdonszelmann mentioned this pull request Jul 13, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

Port #[link_ordinal] to the new attribute parsing infrastructure.

75561c4

Periodic1911 force-pushed the link-ordinal branch from d92419f to 75561c4 Compare July 13, 2025 09:52

matthiaskrgr mentioned this pull request Jul 13, 2025

Rollup of 8 pull requests #143899

Closed

fmease mentioned this pull request Jul 14, 2025

Rollup of 16 pull requests #143912

Closed

jhpratt mentioned this pull request Jul 14, 2025

Rollup of 17 pull requests #143916

Closed

Kobzol mentioned this pull request Jul 14, 2025

Rollup of 10 pull requests #143919

Merged

bors merged commit 93c1027 into rust-lang:master Jul 14, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 14, 2025

Port #[link_ordinal] to the new attribute parsing infrastructure #143217

Port #[link_ordinal] to the new attribute parsing infrastructure #143217

Uh oh!

Conversation

Periodic1911 commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jun 30, 2025

Uh oh!

This comment has been minimized.

bors commented Jul 7, 2025

Uh oh!

This comment has been minimized.

rustbot commented Jul 7, 2025

Uh oh!

rustbot commented Jul 7, 2025

Uh oh!

Periodic1911 commented Jul 7, 2025

Uh oh!

Periodic1911 commented Jul 7, 2025

Uh oh!

JonathanBrouwer commented Jul 7, 2025

Uh oh!

rust-bors bot commented Jul 7, 2025

Uh oh!

WaffleLapkin commented Jul 8, 2025

Uh oh!

rust-bors bot commented Jul 8, 2025

Uh oh!

rust-bors bot commented Jul 8, 2025

Uh oh!

oli-obk Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Periodic1911 Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

rust-bors bot commented Jul 13, 2025

Uh oh!

rust-bors bot commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

Uh oh!

Uh oh!

Periodic1911 commented Jun 29, 2025 •

edited

Loading