Skip to content

Commit fea8bd9

Browse files
authored
Merge pull request #2424 from miikkas/shorter-bot-msgs
Shorten rust-timer's GitHub comments even more
2 parents a5ca0b4 + 7c22ee9 commit fea8bd9

1 file changed

Lines changed: 10 additions & 11 deletions

File tree

site/src/github/comparison_summary.rs

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ async fn summarize_run(
157157
if has_broken_benchmarks {
158158
" - BENCHMARK(S) FAILED"
159159
} else if is_regression {
160-
" - please read the text below"
160+
" - please read:"
161161
} else {
162162
" - no action needed"
163163
},
@@ -262,8 +262,7 @@ fn write_metric_summary(
262262
message: &mut String,
263263
) {
264264
if !primary.is_relevant() && !secondary.is_relevant() {
265-
message
266-
.push_str("This benchmark run did not return any relevant results for this metric.\n");
265+
message.push_str("This perf run didn't have relevant results for this metric.\n");
267266
} else {
268267
match visibility {
269268
DefaultMetricVisibility::Shown => {
@@ -334,22 +333,22 @@ cc @rust-lang/wg-compiler-performance
334333

335334
fn try_run_body(is_regression: bool) -> String {
336335
let next_steps = if is_regression {
337-
"\n\n**Next Steps**: If you can justify the regressions found in \
338-
this try perf run, please do so in sufficient writing \
336+
"\n\n**Next, please**: If you can, justify the regressions found in \
337+
this try perf run in writing \
339338
along with `@rustbot label: +perf-regression-triaged`. If not, \
340-
please fix the regressions and do another perf run. If its results \
341-
are neutral or positive, the label will be automatically removed."
339+
fix the regressions and do another perf run. \
340+
Neutral or positive results will clear the label automatically."
342341
} else {
343342
""
344343
};
345344

346345
let sign = if is_regression { "+" } else { "-" };
347346
format!(
348347
"
349-
Benchmarking this pull request means it may be perf-sensitive \
350-
we'll automatically label it not fit for rolling up. \
351-
You can override this, but we strongly advise not to, \
352-
due to possible changes in compiler perf.{next_steps}
348+
Benchmarking means the PR may be perf-sensitive. \
349+
It's automatically marked not fit for rolling up. \
350+
Overriding is possible but disadvised: \
351+
it risks changing compiler perf.{next_steps}
353352
354353
@bors rollup=never
355354
@rustbot label: -S-waiting-on-perf {sign}perf-regression",

0 commit comments

Comments
 (0)