-
Notifications
You must be signed in to change notification settings - Fork 153
Perf bot should remove S-waiting-on-perf when a bors try build fails #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Technically, the status is accurate -- the build remains queued even if the try build fails; we just wait for the first successful one. I definitely would prefer to avoid an additional comment left on the PR updating the state, so we'd want to work through the API (not rustbot). |
TIL! What happens if you run
👍 |
Yes, it's a noop if the PR is already "looking for try build". |
Should this issue be closed then? |
I think so. Going to go ahead and close it. |
Since the PR author will have to update the PR before perf can benchmark it; e.g. rust-lang/rust#88679 (comment)
The text was updated successfully, but these errors were encountered: