Skip to content

Commit 21b60aa

Browse files
committed
Remove Linkage::Private
This is the same as Linkage::Internal except that it doesn't emit any symbol. Some backends may not support it and it isn't all that useful anyway.
1 parent db4b00f commit 21b60aa

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

src/base.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ pub fn global_linkage_to_gcc(linkage: Linkage) -> GlobalKind {
5151
Linkage::WeakODR => unimplemented!(),
5252
Linkage::Appending => unimplemented!(),
5353
Linkage::Internal => GlobalKind::Internal,
54-
Linkage::Private => GlobalKind::Internal,
5554
Linkage::ExternalWeak => GlobalKind::Imported, // TODO(antoyo): should be weak linkage.
5655
Linkage::Common => unimplemented!(),
5756
}
@@ -68,7 +67,6 @@ pub fn linkage_to_gcc(linkage: Linkage) -> FunctionType {
6867
Linkage::WeakODR => unimplemented!(),
6968
Linkage::Appending => unimplemented!(),
7069
Linkage::Internal => FunctionType::Internal,
71-
Linkage::Private => FunctionType::Internal,
7270
Linkage::ExternalWeak => unimplemented!(),
7371
Linkage::Common => unimplemented!(),
7472
}

src/mono_item.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,7 @@ impl<'gcc, 'tcx> PreDefineCodegenMethods<'tcx> for CodegenCx<'gcc, 'tcx> {
6161
// compiler-rt, then we want to implicitly compile everything with hidden
6262
// visibility as we're going to link this object all over the place but
6363
// don't want the symbols to get exported.
64-
if linkage != Linkage::Internal
65-
&& linkage != Linkage::Private
66-
&& self.tcx.is_compiler_builtins(LOCAL_CRATE)
67-
{
64+
if linkage != Linkage::Internal && self.tcx.is_compiler_builtins(LOCAL_CRATE) {
6865
#[cfg(feature = "master")]
6966
decl.add_attribute(FnAttribute::Visibility(gccjit::Visibility::Hidden));
7067
} else {

0 commit comments

Comments
 (0)