Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Sep 30, 2025

After the change of the website to a static web, we:

  • Should not need the deploy branch protection
  • We should require PRs for the main branch (IMO), as it is now automatically deployed
  • The website team should not need maintain permissions anymore, as Pontoon is no longer used
  • We don't need the Heroku bot anymore

CC @senekor if this looks good.

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/www.rust-lang.org':
      Permission Changes:
        Changing team 'website''s permission from maintain to write
        Removing user 'rust-heroku-deploy-access''s admin permission 
      Branch Protections:
          main
            Required Approving Review Count: 0 => 1
            Requires PR: false => true
          deploy
            Deleting branch protection

@jieyouxu jieyouxu added needs-infra-admin-review This change requires one of the `infra-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Oct 1, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Oct 1, 2025

Rebased.

@Kobzol Kobzol requested a review from jieyouxu November 11, 2025 18:25
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Team access change approved by team-repo-admin, need an infra-admin review for the branch protection changes.

@jieyouxu jieyouxu added the needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. label Nov 12, 2025
@Kobzol Kobzol requested a review from marcoieni November 12, 2025 07:04
@marcoieni marcoieni added this pull request to the merge queue Nov 12, 2025
Merged via the queue into rust-lang:main with commit e04fb20 Nov 12, 2025
3 checks passed
@Kobzol Kobzol deleted the www-update branch November 12, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-infra-admin-review This change requires one of the `infra-admins` to review. needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants