Merge pull request #1975 from Kobzol/issue-data-write

Do not write `IssueData` to the DB when it is unchanged

Author: Urgau

src/db/issue_data.rs

@@ -16,18 +16,19 @@ use tokio_postgres::{Client as DbClient, Transaction};
 
 pub struct IssueData<'db, T>
 where
-    T: for<'a> Deserialize<'a> + Serialize + Default + std::fmt::Debug + Sync,
+    T: for<'a> Deserialize<'a> + Serialize + Default + std::fmt::Debug + Sync + PartialEq + Clone,
 {
     transaction: Transaction<'db>,
     repo: String,
     issue_number: i32,
     key: String,
     pub data: T,
+    initial_data: T,
 }
 
 impl<'db, T> IssueData<'db, T>
 where
-    T: for<'a> Deserialize<'a> + Serialize + Default + std::fmt::Debug + Sync,
+    T: for<'a> Deserialize<'a> + Serialize + Default + std::fmt::Debug + Sync + PartialEq + Clone,
 {
     pub async fn load(
         db: &'db mut DbClient,
@@ -51,25 +52,32 @@ where
             .context("selecting issue data")?
             .map(|row| row.get::<usize, Json<T>>(0).0)
             .unwrap_or_default();
+
+        let initial_data = data.clone();
+
         Ok(IssueData {
             transaction,
             repo,
             issue_number,
             key: key.to_string(),
             data,
+            initial_data,
         })
     }
 
     pub async fn save(self) -> Result<()> {
-        self.transaction
-            .execute(
-                "INSERT INTO issue_data (repo, issue_number, key, data) \
+        // Avoid writing to the DB needlessly.
+        if self.data != self.initial_data {
+            self.transaction
+                .execute(
+                    "INSERT INTO issue_data (repo, issue_number, key, data) \
                  VALUES ($1, $2, $3, $4) \
                  ON CONFLICT (repo, issue_number, key) DO UPDATE SET data=EXCLUDED.data",
-                &[&self.repo, &self.issue_number, &self.key, &Json(&self.data)],
-            )
-            .await
-            .context("inserting issue data")?;
+                    &[&self.repo, &self.issue_number, &self.key, &Json(&self.data)],
+                )
+                .await
+                .context("inserting issue data")?;
+        }
         self.transaction
             .commit()
             .await

src/handlers/check_commits.rs

@@ -24,7 +24,7 @@ mod non_default_branch;
 const CHECK_COMMITS_WARNINGS_KEY: &str = "check-commits-warnings";
 
 /// State stored in the database
-#[derive(Debug, Default, serde::Deserialize, serde::Serialize)]
+#[derive(Debug, Default, serde::Deserialize, serde::Serialize, Clone, PartialEq)]
 struct CheckCommitsWarningsState {
     /// List of the last warnings in the most recent comment.
     last_warnings: Vec<String>,

src/handlers/mentions.rs

@@ -20,7 +20,7 @@ pub(super) struct MentionsInput {
     paths: Vec<String>,
 }
 
-#[derive(Debug, Default, Deserialize, Serialize)]
+#[derive(Debug, Default, Deserialize, Serialize, Clone, PartialEq)]
 struct MentionState {
     paths: Vec<String>,
 }

src/handlers/merge_conflicts.rs

@@ -45,7 +45,7 @@ const MERGE_CONFLICTS_KEY: &str = "merge-conflicts";
 const UNKNOWN_RESCAN_DELAY: Duration = Duration::from_secs(60);
 
 /// State stored in the database for a PR.
-#[derive(Debug, Default, Deserialize, Serialize)]
+#[derive(Debug, Default, Deserialize, Serialize, Clone, PartialEq)]
 struct MergeConflictState {
     /// The GraphQL ID of the most recent warning comment.
     ///

src/handlers/relnotes.rs

@@ -22,7 +22,7 @@ use crate::{
 
 const RELNOTES_KEY: &str = "relnotes";
 
-#[derive(Debug, Default, Deserialize, Serialize)]
+#[derive(Debug, Default, Deserialize, Serialize, Clone, PartialEq)]
 struct RelnotesState {
     relnotes_issue: Option<u64>,
 }

src/handlers/shortcut.rs

@@ -15,7 +15,7 @@ use parser::command::shortcut::ShortcutCommand;
 const AUTHOR_REMINDER_KEY: &str = "author-reminder";
 
 /// State stored in the database for a PR.
-#[derive(Debug, Default, serde::Deserialize, serde::Serialize)]
+#[derive(Debug, Default, serde::Deserialize, serde::Serialize, Clone, PartialEq)]
 struct AuthorReminderState {
     /// ID of the reminder comment.
     reminder_comment: Option<String>,