no zulip notifications

[ehuss]

I noticed that Zulip notifications have not been working this morning.

Config: https://github.com/rust-lang/rust/blob/84b018341284798fa47f8171f4eb04f18f45cf23/triagebot.toml#L115-L121
Topic: https://rust-lang.zulipchat.com/#narrow/stream/268952-edition-2021/topic/Edition.20Bugs
Example issues: rust-lang/rust#88431 rust-lang/rust#88429

[Mark-Simulacrum]

Caused by c0e3c8d which made IssueRepository fail to deserialize from webhooks:

request failed: WebhookError(Issue failed to deserialize

Caused by:
0: at Path { segments: [Map { key: "repository" }, Map { key: "owner" }] }
1: invalid type: map, expected a string at line 1 column 6536)

cc @jackh726

Going to work on a fix now.

[jackh726]

Oh. Hmm

[jackh726]

@Mark-Simulacrum I can submit a fix for this right now if you don't have one

[Mark-Simulacrum]

@jackh726 please take a look at my pr, but I think it should fix this. Happy to consider alternatives though, not sure if my work breaks the graphql anywhere.

[jackh726]

Looks good to me. Graphql types are generated directly from the schema so can't really break.

[ehuss]

Thanks so much for the fast response!

However, it doesn't seem to be working again. There was one notification a little while after this was fixed, but I've filed two more issues since then which have not triggered anything: rust-lang/rust#88442 and rust-lang/rust#88444. What's strange is that rust-lang/rust#88440 made a notification, and that was filed only about 15 minutes before 88442.

[Mark-Simulacrum]

Noted on Zulip as well but I think this is working, just the config requires C-bug applied to issues.