Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for CI before assigning a reviewer #1760

Open
Nadrieril opened this issue Jan 20, 2024 · 3 comments
Open

Wait for CI before assigning a reviewer #1760

Nadrieril opened this issue Jan 20, 2024 · 3 comments
Labels
A-assign-PR Area: PR auto assignment and welcome messages

Comments

@Nadrieril
Copy link
Member

Nadrieril commented Jan 20, 2024

We had a discussion about the review queue on Zulip, and a simple actionable point that came out of it is: rustbot should wait for CI to turn green before assigning a reviewer, to avoid the reviewer needing to remember to check back on the PR later.

As a corollary, it would be nice if @rustbot ready also waited for CI to turn green. In both cases rustbot could say "waiting for CI to turn green" (or set a waiting-on-CI label) to inform the author of what's happening.

@ehuss ehuss added the A-assign-PR Area: PR auto assignment and welcome messages label Jan 21, 2024
@apiraino
Copy link
Contributor

Link to the suggestion on Zulip.

Just to understand how that could work:

a) Apply a waiting-on-ci (or ci-running) on a new PR and when the CI completes, remove that label. Triagebot should react to the event "removed waiting-on-ci label" by throwing a dice and find a reviewer.

or

b) the triagebot should keep an internal state of the PR and choose the reviewer when the CI becomes green

Option (a) a bit easier to implement, but in both cases it should be clarified if there a hook of any kind to be notified that "CI for PR #000 is now green".

@Kobzol
Copy link
Contributor

Kobzol commented Apr 22, 2024

It is possible to listen for webhooks related to check suites assigned to a branch/PR, and find out that it all the workflows of the check suite were green, but that is a bit involved (new bors works like this). I'm not sure if there's a simpler way.

@Kobzol
Copy link
Contributor

Kobzol commented Apr 22, 2024

Maybe this is simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-assign-PR Area: PR auto assignment and welcome messages
Projects
None yet
Development

No branches or pull requests

4 participants