Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified submodules are only warned about on PR creation #1831

Open
kadiwa4 opened this issue Aug 13, 2024 · 0 comments
Open

Modified submodules are only warned about on PR creation #1831

kadiwa4 opened this issue Aug 13, 2024 · 0 comments

Comments

@kadiwa4
Copy link

kadiwa4 commented Aug 13, 2024

rustbot gives a useful warning when someone modifies a submodule in their PR.

Accidental submodule modifications often happen while rebasing PRs onto a newer base commit (example 1, example 2). However, rustbot does not usually warn about that because the accidental modification warning is only sent in the greeting message and not if a submodule modification is introduced later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant